Merge pymake native-commands branch to default and update snapshot in mozilla-central

RESOLVED FIXED in mozilla2.0b4

Status

RESOLVED FIXED
8 years ago
6 months ago

People

(Reporter: ted, Assigned: Mitch)

Tracking

Trunk
mozilla2.0b4
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Now that MozillaBuild 1.5 is released and has Python 2.6, we should be able to use the pymake native-commands branch. I'd like to merge that branch to default in the pymake repo, and then update the snapshot in mozilla-central so we can start using its features in the build system.

bsmedberg, if you have time to glance over my changes (invasive though they are), that'd be helpful. If anyone has any implementation comments or suggestions that'd also be helpful. For example, I'm thinking that the implementation of native commands should probably be changed to just take one parameter, the argument list, and the PythonJob runner class should be setting the environment using os.environ instead, just to simplify command implementation.
FWIW, after patching those threading issues I haven't run into any issues with the branch (been using it for a month or two now).

I don't really have any implementation comments since I don't remember what the code looks like but I'll try to take a look at some point.
(Assignee)

Comment 3

8 years ago
Merged snapshot as of here:
http://hg.mozilla.org/users/bsmedberg_mozilla.com/pymake/rev/e50be3234e39

to here:
http://hg.mozilla.org/mozilla-central/rev/f2c04d62dc9c
Assignee: nobody → mitchell.field
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b4
Blocks: 585010
Backed out due to perf loss.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Depends on: 602506
khuey relanded this after fixing bug 602506:
http://hg.mozilla.org/mozilla-central/rev/942830bbb94c
Status: REOPENED → RESOLVED
Last Resolved: 8 years ago8 years ago
Resolution: --- → FIXED

Updated

6 months ago
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.