581952 - Remove aria-label object attribute (redundant info)

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[David Bolter [:davidb] (NeedInfo me for attention)]

Attachment: patch

Patch attached.

Comment 1

[Marco Zehe (:MarcoZ)]

Comment on attachment 460244 [details] [diff] [review]
patch

r=me. Trivial fix. Thanks!

Comment 2

[alexander :surkov (:asurkov)]

It sounds this patch makes opposite thing to bug description.

Comment 3

[David Bolter [:davidb] (NeedInfo me for attention)]

(In reply to comment #2)
> It sounds this patch makes opposite thing to bug description.

Nope. I think this is the right description. The relevant code in nsAccessible is:

       if (attrFlags & ATTR_BYPASSOBJ)
         continue; // No need to handle exposing as obj attribute here

Comment 4

[alexander :surkov (:asurkov)]

I was confused with left/right sides of diff :)

mochitest please.

Comment 5

[David Bolter [:davidb] (NeedInfo me for attention)]

Sure, this bug is really about making aria-label explicitly not an object attribute, like we did with aria-labelledby. We are doing it late with aria-label because it was added back to the spec since this part of the code was written. I think the fact that it doesn't have the ATTR_VALTOKEN is also enough to ensure it won't appear in the object attributes.

Comment 6

[David Bolter [:davidb] (NeedInfo me for attention)]

Oh actually we do need to be explicit. Reverting summary back to original.

Comment 7

[David Bolter [:davidb] (NeedInfo me for attention)]

Attachment: patch (with test)

Comment 8

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 461307 [details] [diff] [review]
patch (with test)

a=beltzner

Comment 9

[David Bolter [:davidb] (NeedInfo me for attention)]

http://hg.mozilla.org/mozilla-central/rev/f28156f52558
http://hg.mozilla.org/mozilla-central/rev/b2337fe415d7