582039 - JM: xpcshell-test failure on test_bug451678.js

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[David Mandelin [:dmandelin]]

TEST-INFO | (xpcshell/head.js) | test 1 pending

TEST-UNEXPECTED-FAIL | c:/builds/mo-d/_tests/xpcshell/TestXPC/unit/test_bug451678.js | false == true - See following stack:

JS frame :: c:\sources\moo\testing\xpcshell\head.js :: do_throw :: line 273

JS frame :: c:\sources\moo\testing\xpcshell\head.js :: do_check_eq :: line 303

JS frame :: c:\sources\moo\testing\xpcshell\head.js :: do_check_true :: line 315

JS frame :: c:/builds/mo-d/_tests/xpcshell/TestXPC/unit/test_bug451678.js :: run_test :: line 51

JS frame :: c:\sources\moo\testing\xpcshell\head.js :: _execute_test :: line 166

JS frame :: -e :: <TOP_LEVEL> :: line 1

TEST-INFO | (xpcshell/head.js) | exiting test

Comment 1

[David Mandelin [:dmandelin]]

Cause: loadSubScript calls EvaluateUCScript with a scope chain that has a parent (i.e., is not the global object). Our optimizations for globals assume that the initial scope chain and the global are the same, so those optimizations are not valid in this case.

Comment 2

[David Mandelin [:dmandelin]]

Attachment: Patch

Patch deoptimizes globals if the initial scope chain is not the global.

Comment 3

[David Mandelin [:dmandelin]]

http://hg.mozilla.org/projects/jaegermonkey/rev/40d061956e16