Closed Bug 582039 Opened 10 years ago Closed 10 years ago

JM: xpcshell-test failure on test_bug451678.js

Categories

(Core :: JavaScript Engine, defect)

defect
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: dmandelin, Assigned: dmandelin)

References

Details

Attachments

(1 file)

TEST-INFO | (xpcshell/head.js) | test 1 pending

TEST-UNEXPECTED-FAIL | c:/builds/mo-d/_tests/xpcshell/TestXPC/unit/test_bug451678.js | false == true - See following stack:

JS frame :: c:\sources\moo\testing\xpcshell\head.js :: do_throw :: line 273

JS frame :: c:\sources\moo\testing\xpcshell\head.js :: do_check_eq :: line 303

JS frame :: c:\sources\moo\testing\xpcshell\head.js :: do_check_true :: line 315

JS frame :: c:/builds/mo-d/_tests/xpcshell/TestXPC/unit/test_bug451678.js :: run_test :: line 51

JS frame :: c:\sources\moo\testing\xpcshell\head.js :: _execute_test :: line 166

JS frame :: -e :: <TOP_LEVEL> :: line 1

TEST-INFO | (xpcshell/head.js) | exiting test
Summary: TM: xpcshell-test failure on test_bug451678.js → JM: xpcshell-test failure on test_bug451678.js
Cause: loadSubScript calls EvaluateUCScript with a scope chain that has a parent (i.e., is not the global object). Our optimizations for globals assume that the initial scope chain and the global are the same, so those optimizations are not valid in this case.
Attached patch PatchSplinter Review
Patch deoptimizes globals if the initial scope chain is not the global.
Assignee: general → dmandelin
Status: NEW → ASSIGNED
Attachment #460338 - Flags: review?(dvander)
Attachment #460338 - Flags: review?(dvander) → review+
http://hg.mozilla.org/projects/jaegermonkey/rev/40d061956e16
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.