582113 - [stats] Restore ability to pass two files to the script (for split days)

Status: RESOLVED FIXED

(Camino Graveyard :: General, defect)

Description

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Attachment: Fix

Sam informed me I didn't read his instructions carefully enough, and one of my changes broke the ability to gather stats in a single pass for days that are split across log files.

This is a sort-of hacky but flexible patch that lets you pass three arguments *or* two arguments where the second argument is a "quoted list" of files, so you don't have to remember to do something differently when working with 2 files vs 1 file.  (Using the "quoted list" option, you can in fact process arbitrary number of files at once, if necessary--please, no!)

It loses up the ability to pass the filenames in with a path (or name) that contains spaces in it (e.g., /Users/smokey/Cm admin/logs/); I'm not sure how to fix that.  I'm running the script from inside the folder with the log files, so it's not really an issue for me, though I'd like to fix it if possible.

This patch depends on the (corrected) patch for bug 581905 being applied.

Comment 1

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Maybe we could change every "$file" to "$2" "$3" (or the like) and also assign $3 to space if it's not defined, and fix both issues…?

Comment 2

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

(In reply to comment #1)
> Maybe we could change every "$file" to "$2" "$3" (or the like) and also assign
> $3 to space if it's not defined, and fix both issues…?

Nope, we're either going to have one or the other.

Comment 3

[Samuel Sidler (:ss)]

(In reply to comment #0)
> I'm running the script from inside the folder with the log files, so
> it's not really an issue for me, though I'd like to fix it if possible.

As am I. And since we're the only two running it... who cares? Hacky is fine. I'm testing this now.

Comment 4

[Samuel Sidler (:ss)]

Comment on attachment 460368 [details] [diff] [review]
Fix

This works as expected. I tested two different days last year when we had logs split. Ship it.

Comment 5

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

http://hg.mozilla.org/camino/rev/3a7c656bafcb