Bugzilla::Field::Choice implementation for Version.pm and Milestone.pm

ASSIGNED
Assigned to

Status

()

Bugzilla
Administration
--
enhancement
ASSIGNED
8 years ago
4 years ago

People

(Reporter: timello, Assigned: timello)

Tracking

Details

Attachments

(1 attachment, 1 obsolete attachment)

v2.
1.30 KB, patch
Max Kanat-Alexander
: review-
Details | Diff | Splinter Review
(Assignee)

Description

8 years ago
Created attachment 460392 [details] [diff] [review]
v1

I'm not sure what exactly needs to be done. But here is the first patch.
Attachment #460392 - Flags: review?(mkanat)
(Assignee)

Comment 1

8 years ago
Created attachment 463647 [details] [diff] [review]
v2.

it needs the use constant is_active => 1;
Attachment #460392 - Attachment is obsolete: true
Attachment #463647 - Flags: review?(mkanat)
Attachment #460392 - Flags: review?(mkanat)

Comment 2

7 years ago
Comment on attachment 463647 [details] [diff] [review]
v2.

There's no reason for us to implement ChoiceInterface for these fields and then not do something with them. Shouldn't we also be marking them as FIELD_TYPE_SINGLE_SELECT now?
Attachment #463647 - Flags: review?(mkanat) → review-
You need to log in before you can comment on or make changes to this bug.