Closed Bug 582198 Opened 14 years ago Closed 5 years ago

Add enhancements to Find in Page function

Categories

(Firefox for Android Graveyard :: General, defect)

Product:
Firefox for Android Graveyard
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED WONTFIX

People

(Reporter: isandu, Unassigned)

References

Details

Possible enhancements include:

-showing the number of matches on the page, 
-looking for a word while typing and zooming in the results
-firing the Find in page field when starting typing.
(In reply to comment #0)
> -looking for a word while typing and zooming in the results

Irina, what do you mean here? The Find-In-Page helper should zoom in the word you're currently typing, does it not work for you or do you want another behavior?

> -firing the Find in page field when starting typing.

By starting typing, you mean "starting typing on the hardware keyboard" ?
(In reply to comment #1)
> (In reply to comment #0)
> > -looking for a word while typing and zooming in the results
> 
> Irina, what do you mean here? The Find-In-Page helper should zoom in the word
> you're currently typing, does it not work for you or do you want another
> behavior?

I mean when typing the first letter, let's say "t", browser focuses on first word beginning with "t", then when you add "o" browser focuses on first word beginning with "to" and so on. I currently do not see this behavior on the Nexus One or on HTC Desire. 

> 
> > -firing the Find in page field when starting typing.
> 
> By starting typing, you mean "starting typing on the hardware keyboard" ?

Yes
From bug 541817

(In reply to comment #13)
> Filed bug 582198.
> 
> Finding on each key and focusing in on the first result is not confusing and it
> reduces key strokes by allowing the user to observe when the results have been
> narrowed down to the term he is looking for, without having to type the whole
> word and lets him know if the word he's looking for is not there after the
> first few strokes. It's consistent without our "less typing required" strategy.
> For implementation on looking for a word on each key see the default Android
> browser.

I think Mark's point is mostly about performance: zooming and scrolling are heavy operations and are not instantaneous.
Also I'm not fully convinced that searching on _each_ letter make sense compare to searching _after_ a timeout once you stop typing (this doesn't mean you have to type the whole word):
 * you probably don't care about intermediate results for your words while you're typing in, or if you care because of filtering your results it probably means you've _stop_ typing to observe the find results

 * if you stop typing the delay is 500 ms before showing the results which is close to the times your brain needs for perceiving a result ~400ms (but maybe we could move from 500ms to a lower timeout even if 500ms is the default for desktop)

Oh, and I don't see why this is consistent with our "less typing required" strategy since you're still taping the same amount of characters :)

Showing the numbers of results is a good idea I think, and we probably want to disable the previous/next buttons when there is no results before/after (actually we're wrapping into an infinite loop)
(In reply to comment #2)
> (In reply to comment #1)
> > (In reply to comment #0)
> > > -looking for a word while typing and zooming in the results
> > 
> > Irina, what do you mean here? The Find-In-Page helper should zoom in the word
> > you're currently typing, does it not work for you or do you want another
> > behavior?
> 
> I mean when typing the first letter, let's say "t", browser focuses on first
> word beginning with "t", then when you add "o" browser focuses on first word
> beginning with "to" and so on. I currently do not see this behavior on the
> Nexus One or on HTC Desire. 

hmm, this is supposed to works and it works for me on the Nexus One on a yesterday builds.

We can see that together when I'll be at the Paris Office.

> 
> > 
> > > -firing the Find in page field when starting typing.
> > 
> > By starting typing, you mean "starting typing on the hardware keyboard" ?
> 
> Yes

Well, if you use an hardware keyboard you probably wants some shortcuts? like Ctrl+F or "/" instead of having the find as soon as you type (you can type a shortcut or anything else). 
Is it ok for you?
Got it. So (In reply to comment #4)
> (In reply to comment #2)
> > (In reply to comment #1)
> > > (In reply to comment #0)
> > > > -looking for a word while typing and zooming in the results
> > > 
> > > Irina, what do you mean here? The Find-In-Page helper should zoom in the word
> > > you're currently typing, does it not work for you or do you want another
> > > behavior?
> > 
> > I mean when typing the first letter, let's say "t", browser focuses on first
> > word beginning with "t", then when you add "o" browser focuses on first word
> > beginning with "to" and so on. I currently do not see this behavior on the
> > Nexus One or on HTC Desire. 
> 
> hmm, this is supposed to works and it works for me on the Nexus One on a
> yesterday builds.
> 
> We can see that together when I'll be at the Paris Office.
> 

I saw it works now.

> > 
> > > 
> > > > -firing the Find in page field when starting typing.
> > > 
> > > By starting typing, you mean "starting typing on the hardware keyboard" ?
> > 
> > Yes
> 
> Well, if you use an hardware keyboard you probably wants some shortcuts? like
> Ctrl+F or "/" instead of having the find as soon as you type (you can type a
> shortcut or anything else). 
> Is it ok for you?

Here I was thinking about an option like the "Search for text when I start typing" one for the desktop. But I guess a shortcut is also useful.
Ctrl-F shortcut for find in page: Bug 582804
Hardware: x86 → All
madhava, should any of these enhancements be blocking 2.0?
Closing all opened bug in a graveyard component
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.