Closed
Bug 582310
Opened 14 years ago
Closed 14 years ago
Create a local suite of 8 unique web pages
Categories
(Mozilla QA Graveyard :: Mozmill Tests, defect)
Mozilla QA Graveyard
Mozmill Tests
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: u279076, Assigned: u279076)
References
Details
Attachments
(3 files, 3 obsolete files)
225.06 KB,
image/png
|
Details | |
27.50 KB,
patch
|
whimboo
:
review+
|
Details | Diff | Splinter Review |
27.87 KB,
patch
|
Details | Diff | Splinter Review |
This is a tracking bug for creating a suite of 8 unique local web pages for use in various Mozmill tests. The candidate pages are listed below. The local copy should be stripped down of any JS and CSS. It should only have text content and render an image common to all pages (ie. the header image)
Remote URLs:
http://www.mozilla.org
http://www.mozilla.org/about/mission.html
http://www.mozilla.org/community/
http://www.mozilla.org/contribute/
http://www.mozilla.org/projects/
http://www.mozilla.org/about/governance.html
http://www.mozilla.org/about/organizations.html
http://www.mozilla.org/grants/
Please place the files here...
litmus-data:
firefox/layout/mozilla.html
firefox/layout/mozilla_mission.html
firefox/layout/mozilla_community.html
firefox/layout/mozilla_contribute.html
firefox/layout/mozilla_projects.html
firefox/layout/mozilla_governance.html
firefox/layout/mozilla_organizations.html
firefox/layout/mozilla_grants.html
mozmill-data:
firefox/test-files/layout/mozilla.html
firefox/test-files/layout/mozilla_mission.html
firefox/test-files/layout/mozilla_community.html
firefox/test-files/layout/mozilla_contribute.html
firefox/test-files/layout/mozilla_projects.html
firefox/test-files/layout/mozilla_governance.html
firefox/test-files/layout/mozilla_organizations.html
firefox/test-files/layout/mozilla_grants.html
Here is a proof of concept for the local copy of www.mozilla.org. It consists of the following files:
mozilla.html -> 4 kb
favicon.ico -> 4 kb
bg_body_1.jpg -> 12 kb
We can reduce the physical dimensions of the image. I can probably get this down to 3 kb.
Overall, Henrik, can you provide me any feedback on this proof of concept? I'd like to get your feedback before proceeding with the other test pages.
Comment 2•14 years ago
|
||
As long as we have a couple of elements in that page we can access via id, link, name, or else it looks good. Shouldn't a PNG be smaller here for the b/w dino head?
(In reply to comment #2)
> As long as we have a couple of elements in that page we can access via id,
> link, name, or else it looks good. Shouldn't a PNG be smaller here for the b/w
> dino head?
The PNG is 5x bigger (61 kb vs 12 kb)
Updated•14 years ago
|
Component: Mozmill → Mozmill Tests
QA Contact: mozmill → mozmilltests
This patch creates a minimized clone of the 8 Mozilla.org pages mentioned in the original comment.
Aaron, please check this for any errors then flag Henrik for additional review, thanks.
Assignee: nobody → anthony.s.hughes
Status: NEW → ASSIGNED
Attachment #461345 -
Flags: review?(aaron.train)
Comment 5•14 years ago
|
||
Comment on attachment 461345 [details] [diff] [review]
Patch v1 (default)
Read through all pages. Checked all links, matching opening and close blocks and general formatting. Couple of small nits:
mozilla_contribute - You have a indented paragraph tag that is a couple tabs in
mozilla_grants - Perhaps we may want id's on the list items to match the consistency of the other pages
mozilla_mission - To keep consistency lets use 'organizations' or 'org' for all files with the similar id
mozilla.html - To keep consistency lets use 'organizations' or 'org' for all files with similar id
Attachment #461345 -
Flags: review?(aaron.train) → review-
Comment 6•14 years ago
|
||
(In reply to comment #5)
> mozilla_grants - Perhaps we may want id's on the list items to match the
> consistency of the other pages
>
mozilla_governance, sorry
Attachment #462494 -
Flags: review?(aaron.train)
Updated•14 years ago
|
Attachment #462494 -
Flags: review?(aaron.train) → review+
Comment on attachment 462494 [details] [diff] [review]
Patch v2 (litmus-data)
Henrik, can you give this a quick once-over before I commit it?
Attachment #462494 -
Flags: review?(hskupin)
Comment 9•14 years ago
|
||
Comment on attachment 462494 [details] [diff] [review]
Patch v2 (litmus-data)
diff --git a/firefox/layout/.DS_Store b/firefox/layout/.DS_Store
new file mode 100644
Please remove that file from the patch. Don't we list it in .hgignore? Normally it shouldn't get added.
>+ <a href="mozilla.html">
>+ <img id="mozilla_logo" name="mozilla_logo" src="logo.jpg" />
>+ </a>
Would be nice if you could give this or any other a node a name too.
>+ <link rel="shortcut icon" type="image/ico" href="favicon.ico" />
We should check-in different favicons for those pages so we can differentiate between those. Please also put additional files under test-files/images.
Otherwise it looks good.
Attachment #462494 -
Flags: review?(hskupin) → review-
Updated•14 years ago
|
Summary: [mozmill] Create a local suite of 8 unique web pages → Create a local suite of 8 unique web pages
Assignee | ||
Comment 10•14 years ago
|
||
Attachment #462578 -
Flags: review?
Attachment #462578 -
Flags: review? → review?(hskupin)
Attachment #462494 -
Attachment is obsolete: true
Updated•14 years ago
|
Attachment #462578 -
Flags: review?(hskupin) → review+
Assignee | ||
Comment 11•14 years ago
|
||
Landed on litmus-data:
http://hg.mozilla.org/qa/litmus-data/rev/d8de398be9fa
Assignee | ||
Comment 12•14 years ago
|
||
Attachment #461345 -
Attachment is obsolete: true
Attachment #462607 -
Flags: review?(aaron.train)
Comment 13•14 years ago
|
||
Comment on attachment 462607 [details] [diff] [review]
Patch v2 (default)
(In reply to comment #12)
> Created attachment 462607 [details] [diff] [review]
> Patch v2 (default)
>+ <ul id="areas_of_interest">
>+ <li id="browser_choice">
>+ <h5>Web Browser Choice</h5>
>+ <p>
r+, but please adjust that indented paragraph
Attachment #462607 -
Flags: review?(aaron.train) → review+
Assignee | ||
Comment 14•14 years ago
|
||
I'm not sure why the <p> is showing up indented so much in the bugzilla diff. It is not indented this much in the raw html file. In fact it is inline with the <h5>.
Lets see if this version of the patch fixes it.
Attachment #462607 -
Attachment is obsolete: true
Assignee | ||
Comment 15•14 years ago
|
||
(In reply to comment #14)
> Created attachment 462672 [details] [diff] [review]
> Patch v3 (default)
>
> Lets see if this version of the patch fixes it.
That seems to have got it. Not sure what happened there. Anyway, I'll check-in this patch in the morning.
Assignee | ||
Comment 16•14 years ago
|
||
Landed:
http://hg.mozilla.org/qa/mozmill-tests/rev/64c3bcad8869 [default]
http://hg.mozilla.org/qa/mozmill-tests/rev/21282e76b983 [mozilla1.9.2]
http://hg.mozilla.org/qa/mozmill-tests/rev/450cdf8ce866 [mozilla1.9.1]
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Comment 17•14 years ago
|
||
Move of Mozmill Test related project bugs to newly created components. You can
filter out those emails by using "Mozmill-Tests-to-MozillaQA" as criteria.
Product: Testing → Mozilla QA
Updated•5 years ago
|
Product: Mozilla QA → Mozilla QA Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•