582328 - VideoUtils.h:62: warning: 'PRBool MulOverflow32(PRUint32, PRUint32, PRUint32&)' defined but not used

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Daniel Holbert [:dholbert]]

Every file that includes VideoUtils.h & doesn't use the "MulOverflow32" function spams this build warning:
> content/media/VideoUtils.h:62: warning: 'PRBool MulOverflow32(PRUint32, PRUint32, PRUint32&)' defined but not used

Looks like this is because it's a static function defined in the header file -- so each compilation unit gets its own personal copy of the code, but most of them don't use it.

I think one way to fix this would be to make the function inline...  (Then, each _client_ would get its own copy of the code, but that's probably not a big deal since it's a pretty short function...)  Alternately, the function body could go in a new VideoUtils.cpp file. Or maybe there's something else that'd be better than either of these options.

Comment 1

[Chris Pearce [:cpearce (Not reading bugmail)]]

In bug 576539 I have a patch which moves the int overflow aware add/mul into a new VideoUtils.cpp file which should remove this compile error.

Comment 2

[Chris Pearce [:cpearce (Not reading bugmail)]]

Should be fixed by bug 576539 landing...