582340 - Refactor the creation of the Web Console UI to avoid unnecessarily hanging onto nodes

Status: RESOLVED INVALID

(DevTools :: General, defect)

Description

[Patrick Walton (:pcwalton)]

Attachment: Proposed patch.

gavin suggested in bug 582135 that the DOM nodes in the Web Console should be appended to their parents in the same function that they're created in, to avoid having to attach them to the HUD object. This patch implements this change. It moves everything but the filter button creation out of makeFilterToolbar() and into the makeHUDNodes() function, and it renames makeFilterToolbar() to createFilterButtons().

Requesting approval for Firefox 4, as a reviewer-suggested refactoring for bug 582135 (which I am also requesting Fx4 approval for).

Comment 1

[Dietrich Ayala (:dietrich)]

Comment on attachment 460619 [details] [diff] [review]
Proposed patch.

looks good, r+a=me.

Comment 2

[Shawn Wilsher :sdwilsh]

This patch does not apply anymore.

Comment 3

[Patrick Walton (:pcwalton)]

Attachment: Proposed patch (trunk rebase 2010-08-10).

Updated patch to trunk. Requesting re-review because this version is significantly different.

Comment 4

[Mihai Sucan [:msucan]]

Comment on attachment 464649 [details] [diff] [review]
Proposed patch (trunk rebase 2010-08-10).

Looks fine to me, but I am not sure what's the benefit. :) What problem is this patch solving?

Comment 5

[:Gavin Sharp [email: [e-mail]]]

(In reply to comment #4)
> What problem is this patch solving?

Not holding on to nodes longer than necessary, and not having to worry about potential uses of the property outside of the relevant methods.

Comment 6

[Patrick Walton (:pcwalton)]

No longer necessary once bug 601667 lands.