Closed
Bug 582340
Opened 14 years ago
Closed 14 years ago
Refactor the creation of the Web Console UI to avoid unnecessarily hanging onto nodes
Categories
(DevTools :: General, defect)
DevTools
General
Tracking
(status2.0 ?)
RESOLVED
INVALID
Tracking | Status | |
---|---|---|
status2.0 | --- | ? |
People
(Reporter: pcwalton, Assigned: pcwalton)
References
Details
(Whiteboard: [kd4b6] [patchbitrot])
Attachments
(1 file, 1 obsolete file)
5.75 KB,
patch
|
msucan
:
feedback+
|
Details | Diff | Splinter Review |
gavin suggested in bug 582135 that the DOM nodes in the Web Console should be appended to their parents in the same function that they're created in, to avoid having to attach them to the HUD object. This patch implements this change. It moves everything but the filter button creation out of makeFilterToolbar() and into the makeHUDNodes() function, and it renames makeFilterToolbar() to createFilterButtons(). Requesting approval for Firefox 4, as a reviewer-suggested refactoring for bug 582135 (which I am also requesting Fx4 approval for).
Attachment #460619 -
Flags: feedback?(ddahl)
Updated•14 years ago
|
Attachment #460619 -
Flags: feedback?(ddahl) → feedback+
Assignee | ||
Updated•14 years ago
|
Attachment #460619 -
Flags: review?(gavin.sharp)
Updated•14 years ago
|
Whiteboard: [kd4b4]
Assignee | ||
Updated•14 years ago
|
Attachment #460619 -
Flags: review?(gavin.sharp) → review?(dietrich)
Comment 1•14 years ago
|
||
Comment on attachment 460619 [details] [diff] [review] Proposed patch. looks good, r+a=me.
Attachment #460619 -
Flags: review?(dietrich)
Attachment #460619 -
Flags: review+
Attachment #460619 -
Flags: approval2.0+
Updated•14 years ago
|
Keywords: checkin-needed
Assignee | ||
Comment 3•14 years ago
|
||
Updated patch to trunk. Requesting re-review because this version is significantly different.
Attachment #460619 -
Attachment is obsolete: true
Attachment #464649 -
Flags: feedback?(mihai.sucan)
Comment 4•14 years ago
|
||
Comment on attachment 464649 [details] [diff] [review] Proposed patch (trunk rebase 2010-08-10). Looks fine to me, but I am not sure what's the benefit. :) What problem is this patch solving?
Attachment #464649 -
Flags: feedback?(mihai.sucan) → feedback+
Comment 5•14 years ago
|
||
(In reply to comment #4) > What problem is this patch solving? Not holding on to nodes longer than necessary, and not having to worry about potential uses of the property outside of the relevant methods.
Assignee | ||
Updated•14 years ago
|
Attachment #464649 -
Flags: review?(gavin.sharp)
Updated•14 years ago
|
Whiteboard: [kd4b4] → [kd4b5]
Updated•14 years ago
|
Whiteboard: [kd4b5] → [kd4b5] [patchbitrot]
Updated•14 years ago
|
Whiteboard: [kd4b5] [patchbitrot] → [kd4b6] [patchbitrot]
Updated•14 years ago
|
Blocks: devtools4b7
Updated•14 years ago
|
Updated•14 years ago
|
Assignee | ||
Comment 6•14 years ago
|
||
No longer necessary once bug 601667 lands.
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → INVALID
Updated•13 years ago
|
Attachment #464649 -
Flags: review?(gavin.sharp)
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•