582361 - Implement HTML5-compliant navigation to fragment

Status: RESOLVED FIXED

(Core :: DOM: Navigation, task)

Description

[Henri Sivonen (:hsivonen) (temporarily away from Bugzilla)]

Web compat requires percent encoding in the fragment id of a URL to match similarly percent-encoded name attribute value on the <a> element.

Gecko's old HTML parser special-cases the name attribute on <a> to make this work. HTML5 puts the special behavior on the URL processing side at the time of the navigation.

To avoid breaking stuff, we should be HTML5-compliant of both sides (parser and navigation). Currently, only the parser side is compliant. See bug 436006 comment 17.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Making the navigation compliant involves things like bug 483660 (hello, possibly web-incompatible change!), last I checked.  Also see bug 436006 and bug 483304.

By some beta we need to do something here: either fix bug 483660 and audit all consumers and fix them as needed, or change the HTML5 parser behavior.  Questions are:

1)  Which beta.
2)  Who's going to do it?

Comment 2

[Boris Zbarsky [:bzbarsky]]

I guess a third option is somehow revamping how we do navigation so that scrolls to anchor don't involve URIs... but that would only work for same-page anchors anyway.

Comment 3

[Henri Sivonen (:hsivonen) (temporarily away from Bugzilla)]

(In reply to comment #1)
> 2)  Who's going to do it?

Not me in the Firefox 4 timeframe. I guess this means that I'll have add the old Geckoism to the HTML5 parser for now. :-(

Comment 4

[Henri Sivonen (:hsivonen) (temporarily away from Bugzilla)]

(In reply to comment #3)
> (In reply to comment #1)
> > 2)  Who's going to do it?
> 
> Not me in the Firefox 4 timeframe. I guess this means that I'll have add the
> old Geckoism to the HTML5 parser for now. :-(

Filed bug 582940 about the contingency plan in case we don't find Someone Else to fix this bug in time for Firefox 4. (I want to work on this bug, but I'm guessing I won't have the time in the Firefox 4 timeframe.)

Comment 5

[Johnny Stenback (:jst)]

Not blocking on this, but bug 582940 does block.

Comment 6

[Anne (:annevk)]

Hey Alphan, you already did some cleanup to fragment navigation right? Perhaps you want to tackle this too?

Comment 7

[Alphan Chen [:alchen]]

Okay, I will take the bug and investigate the related stuff first.

Comment 8

[Anne (:annevk)]

I wrote more tests for this over at https://github.com/w3c/web-platform-tests/pull/8723 and also updated the HTML Standard at https://github.com/whatwg/html/pull/3111.

It should be all good to implement now, but the new algorithm doesn't match any browser exactly so this will have to be changed carefully.

Comment 9

[Mathew Hodson]

Attachment: Bug 582361 - Align scrolling to a fragment with HTML spec. r?emilio

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ce9c917d3e22
Align scrolling to a fragment with HTML spec. r=emilio

Comment 11

[Cosmin Sabou [:CosminS]]

Backed out for causing wpt failures on scroll-frag-percent-encoded.html

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&revision=ce9c917d3e22a86f9e2a6fb5d5b68cd6d56fb687&searchStr=wpt&selectedTaskRun=CECeu-3JQ2uztpu05vQnxQ.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=429002950&repo=autoland

Backout link: https://hg.mozilla.org/integration/autoland/rev/20207ce727f44fe9605cacefd8d2aa26032ffe62

Comment 12

[Mathew Hodson]

There is an existing Android failure that isn't resolved by this patch, so I will keep that expected FAIL annotation.

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/52586ac7f9ad
Align scrolling to a fragment with HTML spec. r=emilio

Comment 14

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/52586ac7f9ad