Closed Bug 582411 Opened 10 years ago Closed 10 years ago

JM: jsreftest failure on ecma_5\strict\8.7.2.js

Categories

(Core :: JavaScript Engine, defect)

defect
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: dmandelin, Assigned: dmandelin)

References

Details

Attachments

(1 file)

Here is a reduced test case:

  eval('"use strict"; undeclared = 1;');

This should throw an exception, and does without -m. But with -m it completes without throwing.
Attached patch PatchSplinter Review
Summary of solution:

- Change front end so it doesn't create properties for undefined variables in strict mode.
- Change ic::SetProp to call stubs::SetName so it gets the full logic for setting a property, necessary to strict mode errors setting properties
- Update stubs for JSOP_LAMBDA to match interpreter
Assignee: general → dmandelin
Status: NEW → ASSIGNED
Attachment #461343 - Flags: review?(dvander)
Attachment #461343 - Flags: review?(dvander) → review+
http://hg.mozilla.org/projects/jaegermonkey/rev/1853ed52196b
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.