Make unserializable URIs less fatal

RESOLVED FIXED

Status

()

RESOLVED FIXED
9 years ago
9 years ago

People

(Reporter: jdm, Assigned: jdm)

Tracking

Trunk
x86
Linux
Points:
---

Firefox Tracking Flags

(fennec2.0a1+)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

9 years ago
As suggested by bug 516728 comment 66, let's just make this a warning for now.
(Assignee)

Comment 1

9 years ago
Created attachment 460717 [details] [diff] [review]
Patch
Assignee: nobody → josh
Attachment #460717 - Flags: review?(doug.turner)
Comment on attachment 460717 [details] [diff] [review]
Patch

hmm. what about the abort in the serialization?
(Assignee)

Comment 3

9 years ago
Created attachment 460732 [details] [diff] [review]
Patch

Actual patch.
Attachment #460717 - Attachment is obsolete: true
Attachment #460732 - Flags: review?(doug.turner)
Attachment #460717 - Flags: review?(doug.turner)
Attachment #460732 - Flags: review?(doug.turner) → review+
tracking-fennec: ? → 2.0a1+
It seems we need this patch to be able to land other fennec-blocking patches
hmm... I've just changed 
-      NS_ABORT_IF_FALSE(scheme.EqualsASCII("about:") ||
+      NS_WARN_IF_FALSE(scheme.EqualsASCII("about:") ||

in my local builds
http://hg.mozilla.org/mozilla-central/rev/f9214514d547
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.