If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Make unserializable URIs less fatal

RESOLVED FIXED

Status

()

Core
IPC
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: jdm, Assigned: jdm)

Tracking

Trunk
x86
Linux
Points:
---

Firefox Tracking Flags

(fennec2.0a1+)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

7 years ago
As suggested by bug 516728 comment 66, let's just make this a warning for now.
(Assignee)

Comment 1

7 years ago
Created attachment 460717 [details] [diff] [review]
Patch
Assignee: nobody → josh
Attachment #460717 - Flags: review?(doug.turner)

Comment 2

7 years ago
Comment on attachment 460717 [details] [diff] [review]
Patch

hmm. what about the abort in the serialization?
(Assignee)

Comment 3

7 years ago
Created attachment 460732 [details] [diff] [review]
Patch

Actual patch.
Attachment #460717 - Attachment is obsolete: true
Attachment #460732 - Flags: review?(doug.turner)
Attachment #460717 - Flags: review?(doug.turner)

Updated

7 years ago
Attachment #460732 - Flags: review?(doug.turner) → review+
tracking-fennec: ? → 2.0a1+
It seems we need this patch to be able to land other fennec-blocking patches
hmm... I've just changed 
-      NS_ABORT_IF_FALSE(scheme.EqualsASCII("about:") ||
+      NS_WARN_IF_FALSE(scheme.EqualsASCII("about:") ||

in my local builds

Comment 6

7 years ago
http://hg.mozilla.org/mozilla-central/rev/f9214514d547
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.