582467 - Fullscreen video runs through CAIRO_SURFACE images

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Bas Schouten (:bas.schouten)]

In the latest builds on windows it appears fullscreen video is being displayed through CAIRO_SURFACE images, note YCbCr images. This means we at the very least do not get the advantage of hardware YUV conversion.

Comment 1

[Robert O'Callahan (:roc) (email my personal email if necessary)]

I wonder if we should add some hooks so we can test whether we're going through fallback paths.

Comment 2

[Robert O'Callahan (:roc) (email my personal email if necessary)]

I looked into this.

While a fullscreen video is playing, I don't see a problem. I don't see us hitting ImageContainer::GetCurrentAsSurface from nsVideoFrame::BuildLayer, and everything's as fast is it should be.

While a fullscreen video is paused, we *are* calling GetCurrentAsSurface because we're making the video layer "inactive" and rendering it through a ThebesLayer. We should stop doing this for accelerated backends, per discussion with vlad. I can provide a patch for that.

While playing a <video> element in an HTML page in-window, again I don't see a problem. And again, when it's paused there is a problem, as for fullscreen, same fix.

While playing a standalone video file in-window, there is a problem. We find a layer manager, but it's for the widget of the document loaded before we started loading the standalone video file. This is because the new widget hasn't been constructed yet... Bug 130078 will fix that.

Bas, exactly which situation are you concerned about?

Comment 3

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: fix for video layer activity

The fix I mentioned.

Comment 4

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 461473 [details] [diff] [review]
fix for video layer activity

Vlad already wrote this in bug 574481

Comment 5

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 461473 [details] [diff] [review]
fix for video layer activity

Even though this duplicates a Vlad patch, we should land this for beta3 so fullscreen video sticks to accelerated paths. I already discussed this with Vlad and he wrote basically the same code so I think this can just land.

Comment 6

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 461473 [details] [diff] [review]
fix for video layer activity

Well, I suppose I should follow protocol here.

Vlad, I want to land this for beta3.

Comment 7

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Comment on attachment 461473 [details] [diff] [review]
fix for video layer activity

heh, sure

Comment 8

[Robert O'Callahan (:roc) (email my personal email if necessary)]

http://hg.mozilla.org/mozilla-central/rev/681942bf95e0