582583 - Expose a small, simple UI for 'Undo Closed Tab'

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Mark Finkle (:mfinkle) (use needinfo?)]

Bug 579361 added the backend changes to support 'Undo Closed Tab' and implements a simple CTRL+SHIFT+T shortcut key to undo the last closed tab. We should consider making a small UI to expose the feature too.

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

Needs a design

Comment 2

[Jan D]

I made a design suggestion at the session-store planning-page:  https://wiki.mozilla.org/Mobile/Projects/SessionStore

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to comment #2)
> I made a design suggestion at the session-store planning-page: 
> https://wiki.mozilla.org/Mobile/Projects/SessionStore

Jan - The awesomescreen is changing. See https://wiki.mozilla.org/Mobile/Projects/AwesomeScreen2.0

Your design might not fit after those changes.

Comment 4

[Jan D]

(In reply to comment #3)
You are right, it would not fit the way it was planned. But: I can't think of a better place than the screen that you get after you open a new tab: It does not add anything to the chrome and it would be in the right place since the user will open a new tap to reopen the page anyway (or is on the awesomescreen since he closed the last page)
I can think of it being integrated in the history view - the function is anyway a kind of simple history. Actually I suppose "recently closed" as more important (in terms of "being actually used") as the "full" history. I remember that Madhava and Aza have had a discussion about history at the beginning of the project, in which was mentioned that history is hardly used even on desktop computers.

Comment 5

[Madhava Enros [:madhava]]

UI proposal here: http://www.flickr.com/photos/madhava_work/4955421616/

Comment 6

[Jan D]

I like the idea - visibility and mapping are decent.

Comment 7

[Madhava Enros [:madhava]]

Final visual treatment in the Android theme mockups.

Comment 8

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Patch

The patch implement Madhava's mockup except that the closed tab always stays on the bottom-left side of the tabs bar.

Comment 10

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 479736 [details] [diff] [review]
Patch

>+#tabs [anonid="tabs-children"] documenttab:only-child > .documenttab-container > .documenttab-close-container > .documenttab-close {
>+  display: none;
>+}
>+
>+
> #tabs-controls {

extra space and that CSS selector is crazy long

Comment 11

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

(In reply to comment #10)
> Comment on attachment 479736 [details] [diff] [review]
> Patch
> 
> >+#tabs [anonid="tabs-children"] documenttab:only-child > .documenttab-container > .documenttab-close-container > .documenttab-close {
> >+  display: none;
> >+}
> >+
> >+
> > #tabs-controls {
> 
> extra space and that CSS selector is crazy long

fixed

http://hg.mozilla.org/mobile-browser/rev/7bac809eef70

Comment 12

[Tony Chung [:tchung]]

Verified fix on 20101008 builds of android and maemo. filed bug 602962 for screen orientation bug.

Comment 13

[Tony Chung [:tchung]]

litmus test: https://litmus.mozilla.org/show_test.cgi?id=13667