582701 - "Restore All Tabs" broken when there are "New Tab" in the tab strip.

Status: RESOLVED INCOMPLETE

(Firefox :: Session Restore, defect)

Description

[Alice0775 White]

User-Agent:       Mozilla/5.0 (Windows; Windows NT 6.1; WOW64; rv:2.0b3pre) Gecko/20100728 Minefield/4.0b3pre ID:20100728041048
Build Identifier: Mozilla/5.0 (Windows; Windows NT 6.1; WOW64; rv:2.0b3pre) Gecko/20100728 Minefield/4.0b3pre ID:20100728041048

"Restore All Tabs" broken when there are "New Tab"(s) in  the tab strip.
There is one tab failing in restoring.

Reproducible: Always

Steps to Reproduce(The one of the cases to happen surely):
1. Start Minefield with new profile
2. Open 2 tabs with valid urls
3. Open "New Tab" , then [URL1] [URL2] [New Tab] now
4. Close all Tabs except [New Tab]
5. Alt > History > Recently Closed Tabs > Restore All Tabs

Actual Results:
 "Restore All Tabs" fails.
 There is one tab failing in restoring.

Expected Results:
 All Tabs should be restored.


Regression Window:

Works:
http://hg.mozilla.org/mozilla-central/rev/8ec5010204bc
Mozilla/5.0 (Windows; Windows NT 6.1; WOW64; rv:2.0b3pre) Gecko/20100723 Minefield/4.0b3pre ID:20100723155116

Fails:
http://hg.mozilla.org/mozilla-central/rev/6995adf228ed
Mozilla/5.0 (Windows; Windows NT 6.1; WOW64; rv:2.0b3pre) Gecko/20100722 Minefield/4.0b3pre ID:20100723161433

Pushlog
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=8ec5010204bc&tochange=6995adf228ed

Candidate Bug:
Bug 580819 - Session history confusion after transient about:blank page

Comment 1

[Paul O'Shannessy [:zpao] (not bugmail, email directly)]

The patch I have in bug 581937 will fix this and I haven't actually tried to diagnose the problem here (it just happened to work). It's a different enough problem though, so I'll leave this open for now.