582850 - permanent orange test on 64-bit win7: REFTEST TEST-UNEXPECTED-PASS | file:///C:/talos-slave/mozilla-central-w764-opt-u-reftest/build/reftest/tests/modules/libpr0n/test/reftest/jpeg/jpg-size-2x2.jpg

Status: RESOLVED FIXED

(Core :: Graphics: ImageLib, defect)

Description

[Makoto Kato [:m_kato]]

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1280330675.1280331946.10143.gz

JPEG decoder on 64-bit Win doesn't use SSE2 version.  So I think that this orange occurs.  We should not set fails-if on 64-bt Win.

Also I believe that these test failures are same season.


REFTEST TEST-UNEXPECTED-PASS | file:///C:/talos-slave/mozilla-central-w764-opt-u-reftest/build/reftest/tests/modules/libpr0n/test/reftest/jpeg/jpg-size-2x2.jpg |
REFTEST TEST-UNEXPECTED-PASS | file:///C:/talos-slave/mozilla-central-w764-opt-u-reftest/build/reftest/tests/modules/libpr0n/test/reftest/jpeg/jpg-size-5x5.jpg |
REFTEST TEST-UNEXPECTED-PASS | file:///C:/talos-slave/mozilla-central-w764-opt-u-reftest/build/reftest/tests/modules/libpr0n/test/reftest/jpeg/jpg-size-7x7.jpg |
REFTEST TEST-UNEXPECTED-PASS | file:///C:/talos-slave/mozilla-central-w764-opt-u-reftest/build/reftest/tests/modules/libpr0n/test/reftest/jpeg/jpg-size-9x9.jpg |
REFTEST TEST-UNEXPECTED-PASS | file:///C:/talos-slave/mozilla-central-w764-opt-u-reftest/build/reftest/tests/modules/libpr0n/test/reftest/jpeg/jpg-size-15x15.jpg |
REFTEST TEST-UNEXPECTED-PASS | file:///C:/talos-slave/mozilla-central-w764-opt-u-reftest/build/reftest/tests/modules/libpr0n/test/reftest/jpeg/jpg-size-16x16.jpg |
REFTEST TEST-UNEXPECTED-PASS | file:///C:/talos-slave/mozilla-central-w764-opt-u-reftest/build/reftest/tests/modules/libpr0n/test/reftest/jpeg/jpg-size-17x17.jpg |
REFTEST TEST-UNEXPECTED-PASS | file:///C:/talos-slave/mozilla-central-w764-opt-u-reftest/build/reftest/tests/modules/libpr0n/test/reftest/jpeg/jpg-size-31x31.jpg |
REFTEST TEST-UNEXPECTED-PASS | file:///C:/talos-slave/mozilla-central-w764-opt-u-reftest/build/reftest/tests/modules/libpr0n/test/reftest/jpeg/jpg-size-32x32.jpg |
REFTEST TEST-UNEXPECTED-PASS | file:///C:/talos-slave/mozilla-central-w764-opt-u-reftest/build/reftest/tests/modules/libpr0n/test/reftest/jpeg/jpg-size-33x33.jpg |
REFTEST TEST-UNEXPECTED-PASS | file:///C:/talos-slave/mozilla-central-w764-opt-u-reftest/build/reftest/tests/modules/libpr0n/test/reftest/jpeg/jpg-progressive.jpg |
REFTEST TEST-UNEXPECTED-PASS | file:///C:/talos-slave/mozilla-central-w764-opt-u-reftest/build/reftest/tests/modules/libpr0n/test/reftest/jpeg/jpg-gray.jpg |
REFTEST TEST-UNEXPECTED-PASS | file:///C:/talos-slave/mozilla-central-w764-opt-u-reftest/build/reftest/tests/modules/libpr0n/test/reftest/jpeg/jpg-cmyk-1.jpg |
REFTEST TEST-UNEXPECTED-PASS | file:///C:/talos-slave/mozilla-central-w764-opt-u-reftest/build/reftest/tests/modules/libpr0n/test/reftest/jpeg/jpg-cmyk-2.jpg |

Comment 1

[Makoto Kato [:m_kato]]

Attachment: fix

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

It might make more sense to test *only* http.oscpu (or perhaps xr.XPCOMABI), since this really doesn't have anything to do with what widget code we're using.

Comment 3

[Joe Drew (not getting mail)]

Comment on attachment 461504 [details] [diff] [review]
fix

I'm OK with this, but if you want to change it to check only http.oscpu, I'm ok with that too.

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Given that there are a bunch of ifdefs in mozilla/jpeg that say:
#if defined(XP_WIN32) && defined(_M_IX86) && !defined(__GNUC__)
...
#endif
and I suspect those are the ones responsible, I think the right test here is probably:
  fails-if(xr.XPCOMABI=="WINNT_x86-msvc")

Comment 5

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

I have this in my patch queue ready to land.  (I actually meant xulRuntime.XPCOMABI , which is what I'm using.)

Comment 6

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

http://hg.mozilla.org/mozilla-central/rev/4643426a1523