582917 - if blank tab gets replaced for undo close tab, don't add it to closed tab list

Status: RESOLVED DUPLICATE of bug 581937

(Firefox :: Session Restore, defect)

Description

[Frank Yan (:fryn)]

Steps to reproduce:

1. Open a blank tab.
2. Detach the blank tab to a new window 2.
3. Open a new tab in window 2, and load some non-blank web page in it.
4. Close that new tab. Now the blank tab is focused.
5. Undo Close Tab. The blank tab is replaced.
6. Undo Close Tab. The blank tab reappears?!

A second way to reproduce with the following preconditions:
* browser.tabs.closeWindowWithLastTab is false
* browser.startup.homepage is not about:blank
1. Open a new window.
2. Close the tab, so a blank tab appears in its place.
3. Open a new tab, and load some non-blank web page in it.
4. Close that new tab. Now the blank tab is focused.
5. Undo Close Tab. The blank tab is replaced.
6. Undo Close Tab. The blank tab reappears?!

Expected results:
Nothing happens upon 'Undo Close Tab' in step 6.
(Use ctrl/cmd+shift+t to test 'Undo Close Tab' if the menu item is disabled/hidden.)

Note that the following steps do not reproduce this:
* browser.startup.homepage is about:blank
1. Open a new window.
2. Open a new tab, and load some non-blank web page in it.
3. Close the new tab.
4. Undo Close Tab. The blank tab is replaced.
5. Undo Close Tab. Nothing happens.

Comment 1

[Frank Yan (:fryn)]

Blank tabs (with no history, etc.) in general should not be added to the undo stack.