583107 - Get rid of FAH_getCurrentContext() method

Status: RESOLVED FIXED

(DevTools :: Console, defect)

Description

[David Dahl :ddahl]

To quote gavin in bug 579954:

> >   getCurrentContext: function FAH_getCurrentContext()
> 
> I'd like to get rid of this function. I don't fully understand the ownership
> models of the various objects involved, though. I assume there is only ever a
> single HUDService instance, and it appears that it keeps track of individual
> content windows. It's easy (though not necessarily cheap) to map content
> windows to their chrome window parent (as the snippet of code above does), so
> there should be no need to ever get the "most recent window".

snippet:

var xulWindow = aContentWindow.QueryInterface(Ci.nsIInterfaceRequestor)
                              .getInterface(Ci.nsIWebNavigation)
                              .QueryInterface(Ci.nsIDocShell)
                              .chromeEventHandler.ownerDocument.defaultView;

Comment 1

[David Dahl :ddahl]

an email conversation was started, but I'll continue it here:

----- Original Message -----
From: "Kevin Dangoor" <[e-mail]>
To: "david Dahl" <[e-mail]>
Sent: Thursday, August 5, 2010 6:31:08 AM
Subject: FAH_getCurrentContext

Hi David,

I don't understand the importance of this bug:

https://bugzilla.mozilla.org/show_bug.cgi?id=583107

Is this just a removal of code, or is there a change in behavior here? (And,
most importantly, is there any user impact?)
-------------------------------

I think gavin means that we need a less "shortcuty" way to identify and get a handle on the dom window or web console that is currently focused. So this is not just a removal of code but also writing a better method that is part of the HUDService.

Comment 2

[:Gavin Sharp [email: [e-mail]]]

There's no direct user impact, apart from possible bugs related to using the "focused" window rather than a direct reference. Just a code sanity issue that I think we should fix.

Comment 3

[Kevin Dangoor]

OK, code sanity issue can wait a little bit to get to it. Thanks for the clarification!