Closed
Bug 583148
Opened 14 years ago
Closed 14 years ago
Use MeegoTouch specific widgets instead of Qt ones if it is enabled
Categories
(Core Graveyard :: Widget: Qt, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: steffen.imhof, Assigned: steffen.imhof)
References
Details
Attachments
(1 file, 3 obsolete files)
|
3.46 KB,
patch
|
dougt
:
review-
|
Details | Diff | Splinter Review |
The patch switches the MozQGraphicsView against a combination of MozMSceneWindow and MozMGraphicsView if the build is a MeegoTouch enabled one. This help to integrate the browser better into the platform.
Attachment #461426 -
Flags: review?(doug.turner)
|
Assignee | |
Comment 1•14 years ago
|
||
MApplication is needed for this, added dependency.
Depends on: 583179
|
||
Comment 2•14 years ago
|
||
Comment on attachment 461426 [details] [diff] [review] Patch to use MWidgets Change review on behalf of doug. Do not forget to change the USE_MEEGOTOUCH into MOZ_PLATFORM_MEEGO before pushing.
Attachment #461426 -
Flags: review?(doug.turner) → review?(romaxa)
|
|
Assignee | |
Comment 3•14 years ago
|
||
Updated patch to use new #define name as changed in 583039
Attachment #461426 -
Attachment is obsolete: true
Attachment #462101 -
Flags: review?(romaxa)
Attachment #461426 -
Flags: review?(romaxa)
|
||
Comment 4•14 years ago
|
||
Comment on attachment 462101 [details] [diff] [review] Patch changed to use new #define name +#ifdef MOZ_PLATFORM_MEEGO use the right #define. Drop the getenv i love you.
Attachment #462101 -
Flags: review?(romaxa) → review-
|
||
Comment 5•14 years ago
|
||
Yep, that variable was used when meegotouch was very unstable... of course libmeegotouch still not perfect, but there no any reason to keep it for target builds... we can drop it env variable support now
|
|
Assignee | |
Comment 6•14 years ago
|
||
This version of the patch has the runtime disabling of MeegoTouch widgets removed and uses the new #define name MOZ_ENABLE_MEEGOTOUCH
Assignee: nobody → steffen.imhof
Attachment #462101 -
Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #462211 -
Flags: review?(doug.turner)
|
|
||
Updated•14 years ago
|
Attachment #462211 -
Flags: review?(doug.turner) → review+
|
|
Assignee | |
Comment 7•14 years ago
|
||
It turned out, skipping MeegoTouch in the content process is still wanted until the puppet widgets arrive, so I wrapped the initialization with a check again. (using XRE_GetProcessType() this time)
Attachment #462211 -
Attachment is obsolete: true
Attachment #462440 -
Flags: review?(doug.turner)
|
|
||
Comment 8•14 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/80e59d5d7299
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
|
|
||
Comment 9•14 years ago
|
||
Comment on attachment 462440 [details] [diff] [review] Patch now checks if it is running in the chrome process before using MeegoTouch patch already landed. If there is a follow up, please create a new bug. Thanks!
Attachment #462440 -
Flags: review?(doug.turner) → review-
|
||
Updated•8 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•