Closed Bug 583183 Opened 14 years ago Closed 14 years ago

Use gzip compression for tinderbox logs

Categories

(Release Engineering :: General, defect)

x86_64
Linux
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: catlee, Assigned: catlee)

References

Details

Attachments

(3 files)

Attached patch Fix gzip formatSplinter Review
Using gzip compression is significantly faster than using bzip2.

Needs some buildbot patches first, then buildbotcustom work.

The buildbot patch can be applied to both 0.7.10 masters and 0.8.0.
Attachment #461469 - Flags: review?(bhearsum)
Speeding up this step is important because compressing the logs happens in the mail thread, and can block everything else from happening for a significant amount of time:

2010-07-29 22:44:57-0700 [Broker,4666,10.250.49.96]  <Build Rev3 Fedora 12x64 tryserver debug test mochitests-1/5>: build finished
2010-07-29 22:45:47-0700 [Broker,4666,10.250.49.96] sending mail (864601 bytes) to ['tinderbox-daemon@tinderbox.mozilla.org']
2010-07-29 22:45:47-0700 [Broker,4666,10.250.49.96] Starting factory <twisted.mail.smtp.SMTPSenderFactory instance at 0x1a6f8e8c>

Here the master process was blocked for 50 seconds compressing this log file.
Comment on attachment 461469 [details] [diff] [review]
Fix gzip format

Aha, I thought one of these was busted.
Attachment #461469 - Flags: review?(bhearsum) → review+
Comment on attachment 461471 [details] [diff] [review]
Use logCompression='gzip' for TinderboxMailNotifiers (default branch)

Looks fine. If you're planning to update Buildbot on the 0.7.x masters can you update mozilla2{,-staging}/*, too? Probably not necessary to update those masters, though.
Attachment #461471 - Flags: review?(bhearsum) → review+
Attachment #461470 - Flags: review?(bhearsum) → review+
Comment on attachment 461469 [details] [diff] [review]
Fix gzip format

changeset:   76:bbb93feea7a2
Attachment #461469 - Flags: checked-in+
Assignee: nobody → catlee
Blocks: 583819
Comment on attachment 461470 [details] [diff] [review]
Use logCompression='gzip' for TinderboxMailNotifiers (0.8.0 branch)

changeset:   851:edba7275dec1
Attachment #461470 - Flags: checked-in+
Comment on attachment 461471 [details] [diff] [review]
Use logCompression='gzip' for TinderboxMailNotifiers (default branch)

changeset:   853:d94b2b27d220
Attachment #461471 - Flags: checked-in+
e.g.

http://tinderbox.mozilla.org/showlog.cgi?log=TraceMonkey/1280928709.1280928900.13614.gz&fulltext=1
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Blocks: 589136
Product: mozilla.org → Release Engineering
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: