583187 - Remove Flash 10.0 + Exposé crash work-around from 2.1

Status: RESOLVED FIXED

(Camino Graveyard :: Plug-ins, defect)

Description

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Attachment: Removes the code

In bug 577567 comment 7-10, we discussed removing the work-around we added back in bug 465178 to stop Flash 10.0 from crashing when Flash fullscreen was ended by Exposé or window cycling.  Gecko focus has changed again under 1.9.2, and the hack appears to no longer be needed.

I've briefly tested this patch with Flash 10.0r45 in my debug build, and, indeed, Flash 10.0 doesn't crash us.  I don't think we need a full suite of Flash 10.0rOldRevision tests, but I would appreciate someone double-checking my results, preferably in a non-debug build, before we land this.

Comment 1

[philippe (part-time)]

Comment on attachment 461479 [details] [diff] [review]
Removes the code

1. tested  with flash 10.1 r53 then 10.0 r45 – youtube, embedded youtube, vimeo, guardian.co.uk
2. Exposé triggered from the keyboard (F3 - all windows) and mouse with hotspot, cycling through windows with custom keyboard shortcut

(10.0r45 is what currently ships with OS X 10.6/10.5 latest security update, afaik)

Camino changeset: e47c84bb4145

--> no crashes so far

----
interestingly, while testing with 10.0r45, I saw this in console - just after pressing F3 (exposé all windows) and clicking on the Camino window:
7/30/10 4:42:07 PM	[0x0-0x185185].org.mozilla.camino[87678]	Fri Jul 30 16:42:07 yugao.local Camino[87678] <Error>: kCGErrorIllegalArgument: _CGSFindSharedWindow: WID 2125
7/30/10 4:42:07 PM	[0x0-0x185185].org.mozilla.camino[87678]	Fri Jul 30 16:42:07 yugao.local Camino[87678] <Error>: kCGErrorIllegalArgument: CGSRemoveSurface: Invalid window 0x84d

Comment 2

[Stuart Morgan]

Comment on attachment 461479 [details] [diff] [review]
Removes the code

sr=smorgan

Comment 3

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

http://hg.mozilla.org/camino/rev/4d563a5645d9