583238 - Investigate ways to pass more context to FAC.autoCompleteSearch

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Mark Finkle (:mfinkle) (use needinfo?)]

With e10s, we have problems passing the "field" param to FAC.autoCompleteSearch. We were passing a faked object that included a "maxLength" property for the default FAC service. Fennec now has it's own FAC override component (see bug 578691) and it would like to use more context from the field.

We can try to make a fake nsIDOMHTMLInputElement, but we'll never be able to fully simulate the interface.

We can try making a new param or a new method, that allows us to pass extra context.

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

From Mounir Lamouri:

I quickly look at the patch (in bug 578691) and it looks like you get the type with getAttribute and then compares it to 'email' and 'tel' but the type attribute isn't case sensitive so type='EMAIL' should work too. You can use .type which returns the type in lower case but you will have to depend on bugs implementing that (should land for ff4).

-----

So we could add .type to our fake object to get better support with very little effort.

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: patch

This approach works well and is forward compatible

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: patch 2

Now with more tests

Comment 4

[Matt Brubeck (:mbrubeck)]

Comment on attachment 461614 [details] [diff] [review]
patch 2

>+// In case there are real contacts that could mess up our test counts
>+let preEmailCount = fac.autoCompleteSearch("email", "", null, null).matchCount;
>+let prePhoneCount = fac.autoCompleteSearch("tel", "", null, null).matchCount;

This looks fine, but would it be more robust to just remove the real contact provider for these tests, using |_contacts.providers = [];|?

r=mbrubeck

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to comment #4)
> Comment on attachment 461614 [details] [diff] [review]
> patch 2
> 
> >+// In case there are real contacts that could mess up our test counts
> >+let preEmailCount = fac.autoCompleteSearch("email", "", null, null).matchCount;
> >+let prePhoneCount = fac.autoCompleteSearch("tel", "", null, null).matchCount;
> 
> This looks fine, but would it be more robust to just remove the real contact
> provider for these tests, using |_contacts.providers = [];|?
> 
> r=mbrubeck

LOL! That was exactly my first approach. But then I worried about making _providers inaccessible, breaking these tests. So I switched to this way for now.

Comment 6

[Mark Finkle (:mfinkle) (use needinfo?)]

pushed:
http://hg.mozilla.org/mobile-browser/rev/143255567eca