Closed
Bug 583280
Opened 15 years ago
Closed 15 years ago
Align optgroup labels with top-level options
Categories
(Firefox for Android Graveyard :: General, defect)
Firefox for Android Graveyard
General
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: mbrubeck, Assigned: mbrubeck)
References
Details
(Keywords: polish, Whiteboard: [has-patch])
Attachments
(2 files)
|
703 bytes,
patch
|
mfinkle
:
review+
|
Details | Diff | Splinter Review |
|
46.06 KB,
image/png
|
madhava
:
ui-review+
|
Details |
comparison screenshots
This seems both prettier and more logical, and matches the desktop browser rendering more closely.
See the attached screenshot; I'll wait for Madhava's ui-review before checking anything in.
Attachment #461572 -
Flags: review?(mark.finkle)
|
Assignee | |
Comment 1•15 years ago
|
||
Attachment #461573 -
Flags: ui-review?(madhava)
|
||
Updated•15 years ago
|
Attachment #461573 -
Flags: ui-review?(madhava) → ui-review+
|
||
Comment 2•15 years ago
|
||
If we change the alignment like that I'm a bit afraid that the user think the row is a checkbox.
|
|
Assignee | |
Updated•15 years ago
|
Whiteboard: [has-patch]
|
||
Comment 3•15 years ago
|
||
Comment on attachment 461572 [details] [diff] [review]
patch
make a custom @optgroup_padding@ variable. I was using 0.10583334 as a px -> mozmm conversion and rounding to 2 decimals (54px -> 5.72mozmm)
Attachment #461572 -
Flags: review?(mark.finkle) → review+
|
|
Assignee | |
Comment 4•15 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
|
||
Comment 5•14 years ago
|
||
The UI has been changed on the latest Nightly build. I will close this bug as verified fixed.
--
Mozilla/5.0 (Android;Linux armv7l;rv:9.0a1)Gecko/20110920
Firefox/9.0a1 Fennec/9.0a1
Device: Samsung Galaxy S
OS: Android 2.2
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•