583296 - [Mac] [OOPP] Beach balling when I trigger the flash context menu

Status: RESOLVED FIXED

(Core Graveyard :: Plug-ins, defect)

Description

[Marcia Knous [:marcia]]

Seen while running  Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:2.0b3pre) Gecko/20100730 Minefield/4.0b3pre

STR:
1. Load blip.tv come.
2. Right click to expose the context menu
3. Try to select one of the "quality" options
4. If you move the cursor away from the menu, you see beach balling.

I have also seen the same behavior when performing the same operations on youtube.com

Comment 1

[Benoit Girard (:BenWa)]

I'll take this bug. I know what the problem here. My surprise is that on my machine I don't get 'beach balling', I just have the rendering pause during the duration of the menu.

Comment 2

[Benoit Girard (:BenWa)]

Attachment: Fix StartDrawingPlugin to correct detect nested paint events. v1

Previously we used to detect if we we're in a paint event using 'mView != [NSView focusView]' except this doesn't work with out-of-process. My change instead checks if we dispatched a paint event. This appears to be more reliable.

Comment 3

[Benoit Girard (:BenWa)]

Pushed to mozilla-central:
http://hg.mozilla.org/mozilla-central/rev/5e9c05dbe8d6

Comment 4

[Benoit Girard (:BenWa)]

Attachment: Fix leak

I forgot to un-comment 2 lines that release memory.

Also does this object doesn't need to be release-ed since it doesn't alloc right?
  NSTimer *eventTimer = [NSTimer timerWithTimeInterval:EVENT_PROCESS_DELAY
                             target:eventProcessor selector:@selector(onTick)
                             userInfo:nil repeats:TRUE];

Comment 5

[Benoit Girard (:BenWa)]

Attachment: fix leak & error return

Sorry for bugspam, found another problem :(.

Comment 6

[Josh Aas]

(In reply to comment #4)

> Also does this object doesn't need to be release-ed since it doesn't alloc
> right?
>   NSTimer *eventTimer = [NSTimer timerWithTimeInterval:EVENT_PROCESS_DELAY
>                              target:eventProcessor selector:@selector(onTick)
>                              userInfo:nil repeats:TRUE];

It's not that it does or doesn't alloc (you don't really have a way to know what it does), but whatever it does it returns an autoreleased object which means it isn't your responsibility to release it.