Closed Bug 583296 Opened 11 years ago Closed 11 years ago

[Mac] [OOPP] Beach balling when I trigger the flash context menu

Categories

(Core :: Plug-ins, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Tracking Status
blocking2.0 --- betaN+

People

(Reporter: marcia, Assigned: BenWa)

References

()

Details

(Keywords: regression)

Attachments

(2 files, 1 obsolete file)

Seen while running  Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:2.0b3pre) Gecko/20100730 Minefield/4.0b3pre

STR:
1. Load blip.tv come.
2. Right click to expose the context menu
3. Try to select one of the "quality" options
4. If you move the cursor away from the menu, you see beach balling.

I have also seen the same behavior when performing the same operations on youtube.com
blocking2.0: --- → ?
I'll take this bug. I know what the problem here. My surprise is that on my machine I don't get 'beach balling', I just have the rendering pause during the duration of the menu.
Assignee: nobody → b56girard
Status: NEW → ASSIGNED
blocking2.0: ? → betaN+
Summary: [Mac] Beach balling when I trigger the flash context menu → [Mac] [OOPP] Beach balling when I trigger the flash context menu
Previously we used to detect if we we're in a paint event using 'mView != [NSView focusView]' except this doesn't work with out-of-process. My change instead checks if we dispatched a paint event. This appears to be more reliable.
Attachment #466020 - Flags: review?
Attachment #466020 - Flags: review? → review?(joshmoz)
Attachment #466020 - Flags: review?(joshmoz) → review+
Pushed to mozilla-central:
http://hg.mozilla.org/mozilla-central/rev/5e9c05dbe8d6
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Attached patch Fix leak (obsolete) — Splinter Review
I forgot to un-comment 2 lines that release memory.

Also does this object doesn't need to be release-ed since it doesn't alloc right?
  NSTimer *eventTimer = [NSTimer timerWithTimeInterval:EVENT_PROCESS_DELAY
                             target:eventProcessor selector:@selector(onTick)
                             userInfo:nil repeats:TRUE];
Attachment #466020 - Attachment is obsolete: true
Attachment #466187 - Flags: review?
Attachment #466187 - Flags: review? → review?(joshmoz)
Attachment #466187 - Attachment is patch: true
Attachment #466187 - Attachment mime type: application/octet-stream → text/plain
Attachment #466020 - Attachment is obsolete: false
Sorry for bugspam, found another problem :(.
Attachment #466187 - Attachment is obsolete: true
Attachment #466190 - Flags: review?(joshmoz)
Attachment #466187 - Flags: review?(joshmoz)
(In reply to comment #4)

> Also does this object doesn't need to be release-ed since it doesn't alloc
> right?
>   NSTimer *eventTimer = [NSTimer timerWithTimeInterval:EVENT_PROCESS_DELAY
>                              target:eventProcessor selector:@selector(onTick)
>                              userInfo:nil repeats:TRUE];

It's not that it does or doesn't alloc (you don't really have a way to know what it does), but whatever it does it returns an autoreleased object which means it isn't your responsibility to release it.
Attachment #466190 - Flags: review?(joshmoz) → review+
Attachment #466190 - Flags: approval2.0+
You need to log in before you can comment on or make changes to this bug.