583333 - error "timeout is not defined" in controller.js

Status: VERIFIED FIXED

(Testing Graveyard :: Mozmill, defect)

Description

[Heather Arthur [:harth]]

Get timeout is not defined", "lineNumber": 428, "stack": "([object Object],true)@resource://mozmill/modules/controller.js:428

when I run:
 mozmill -b ~/Shiretoko.app/ --show-errors -t ~/mozmill-tests/firefox/testTabbedBrowsing/testOpenInForeground.js

The line in question does have a 'timeout' that appears to not be initialized anywhere. Regressed with this commit:

http://github.com/mozautomation/mozmill/commit/45213c70e89c05d8a728aa9ca293ffe1fad7b660

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Dammit, that's true and there are also other instances:

-    this.waitForEval("subject.checked == " + state, 500, 100, element);
+    this.waitFor(function() {
+      return element.checked == state;
+    }, timeout, interval);

We should simply revert it to 500, 100. Meanwhile I feel really bad about all those regressions my new feature has been introduced and no-one has seen during the review cycle. :/

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Patch v1

These are all instances I can find.

Comment 3

[Heather Arthur [:harth]]

Comment on attachment 461658 [details] [diff] [review]
Patch v1

cool, thanks Henrik.

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Upps, landed without approval. I hope it's ok, for that regression:
http://github.com/mozautomation/mozmill/commit/0132f28ccb10d1a1b34574f86006bdfcb0895668
http://github.com/mozautomation/mozmill/commit/c1721badf61b46e7772f3a09968ed0a0045ea5e8

Comment 5

[Geo Mealer [:geo] -- This account is inactive after 2015-07-07]

Verified by running testTabbedBrowsing/testOpenInForeground.js