583347 - Convert all uses of Weave.Svc.* to use Services.* or Cc...

Status: RESOLVED WONTFIX

(Firefox :: Sync, defect)

Description

[Paul O'Shannessy [:zpao] (not bugmail, email directly)]

There are a number of cases where converting Weave.Svc.* to the Services.* equivalent is not an easy switch (mostly the ones where Weave.Svc.X is actually a wrapper around the service).

So I'm doing this in a followup because it's not worth the time spent now.

Comment 1

[Philipp von Weitershausen [:philikon]]

We need to keep using Weave.Svc.* in services/sync as long as the add-on is also supposed to work on Firefox 3.6 where Services.jsm doesn't exist.

If this bug is purely about the Firefox UI integration bits, it should probably go back into the Firefox component.

Comment 2

[Paul O'Shannessy [:zpao] (not bugmail, email directly)]

(In reply to comment #1)
> If this bug is purely about the Firefox UI integration bits, it should probably
> go back into the Firefox component.

That is what it's for. Shawn made a boo-boo.

Comment 3

[Philipp von Weitershausen [:philikon]]

We got rid of all custom Svc.* aliases that are also available in Services.jsm et.al. in bug 648364. The remaining ones are either nicer wrappers around existing services (Svc.Prefs, Svc.Obs) or not available from anywhere else. (I don't see why we should use Cc[...].getService(...) instead of a lazy service getter.)