Closed
Bug 583411
Opened 14 years ago
Closed 14 years ago
Context menu key events are generated with the wrong target
Categories
(Core :: Widget: Win32, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: neil, Assigned: neil)
Details
Attachments
(3 files)
727 bytes,
patch
|
jimm
:
review+
|
Details | Diff | Splinter Review |
465 bytes,
patch
|
jimm
:
review-
|
Details | Diff | Splinter Review |
579 bytes,
patch
|
jimm
:
review+
joe
:
approval2.0+
|
Details | Diff | Splinter Review |
When I try to open the context menu with the keyboard, it probably does not open, or if it does, it has the wrong context. This is because it fires with the document as its target. The popup manager then copies the incorrect target to document.popupNode. Instead the focused node should be the event target. I tried in a build from a week ago and the event target when canvas has focus is actually the HTMLHtmlElement, so even then it's not the document.
Assignee | ||
Comment 1•14 years ago
|
||
Turns out I was running an x86_64 build by mistake, which has a bug. Morphing.
Component: DOM: Events → Widget: Win32
Keywords: regression
OS: Windows XP → Windows Server 2008
QA Contact: events → win32
Hardware: x86 → x86_64
Assignee | ||
Comment 2•14 years ago
|
||
Assignee | ||
Comment 3•14 years ago
|
||
This "corrects" our cheat to correctly test all four bytes at once.
Attachment #461872 -
Flags: review?(jmathies)
Assignee | ||
Comment 4•14 years ago
|
||
Since Windows actually passes -1, just test for -1...
Attachment #461873 -
Flags: review?(jmathies)
Comment 5•14 years ago
|
||
I'm a fan of the literal MSDN interpretation, but proposed wfm as well.
Updated•14 years ago
|
Attachment #461870 -
Flags: review?(jmathies) → review+
Updated•14 years ago
|
Attachment #461872 -
Flags: review?(jmathies) → review-
Updated•14 years ago
|
Attachment #461873 -
Flags: review?(jmathies) → review+
Assignee | ||
Comment 6•14 years ago
|
||
Comment on attachment 461873 [details] [diff] [review] Proposed patch Seeking approval for a trivial Win64 correctness fix.
Attachment #461873 -
Flags: approval2.0?
Comment 7•14 years ago
|
||
Comment on attachment 461873 [details] [diff] [review] Proposed patch Is there any way we can add a test to make sure that context menus brought up from the keyboard work?
Assignee | ||
Comment 8•14 years ago
|
||
(In reply to comment #7) > Is there any way we can add a test to make sure that context menus brought up > from the keyboard work? Not obviously, as this depends on being able to synthesize an OS event, the bug being that the OS event was incorrectly converted to a Gecko event.
Comment 9•14 years ago
|
||
Comment on attachment 461873 [details] [diff] [review] Proposed patch OK, that's too bad.
Attachment #461873 -
Flags: approval2.0? → approval2.0+
Assignee | ||
Comment 10•14 years ago
|
||
Pushed changeset c6c281075d0b to mozilla-central.
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•