Closed
Bug 583429
Opened 14 years ago
Closed 14 years ago
TM: Array.prototype lost its length property
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: gal, Assigned: gal)
References
Details
(Whiteboard: fixed-in-tracemonkey)
Attachments
(1 file)
|
3.67 KB,
patch
|
brendan
:
review+
|
Details | Diff | Splinter Review |
I changed the code to directly construct a slow array, but that lost the length property, which is only created as a dense array is slowified. Insane.
|
Assignee | |
Comment 1•14 years ago
|
||
Assignee: general → gal
|
|
Assignee | |
Comment 2•14 years ago
|
||
Comment on attachment 461730 [details] [diff] [review]
patch
This patch removes a change I did before (make array.proto be constructed as slow arrays right away).
Attachment #461730 -
Flags: review?(brendan)
|
||
Comment 3•14 years ago
|
||
Comment on attachment 461730 [details] [diff] [review]
patch
The js_InitClass reversion is good, hope we can avoid any special-casing there if we try again to have js_InitArrayClass init js_SlowArrayClass not js_ArrayClass.
/be
Attachment #461730 -
Flags: review?(brendan) → review+
|
|
Assignee | |
Comment 4•14 years ago
|
||
Whiteboard: fixed-in-tracemonkey
|
||
Comment 5•14 years ago
|
||
Test?
|
|
Assignee | |
Comment 6•14 years ago
|
||
|
|
||
Comment 7•14 years ago
|
||
I don't think that does what you think it does: you really want
Object.getOwnPropertyNames(Array.prototype).indexOf("length") >= 0
Right?
|
|
Assignee | |
Comment 8•14 years ago
|
||
Mhm. Right. That test is a little stupid. Want to fix it? On an iphone.
|
|
Assignee | |
Comment 10•14 years ago
|
||
Thanks =)
|
||
Comment 12•14 years ago
|
||
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•