583442 - Window background in full screen mode should be some other color besides dark grey with tabs on top

Status: RESOLVED WONTFIX

(Firefox :: Theme, defect)

Description

[Gabriela [:gaby2300]]

User-Agent:       Mozilla/5.0 (Windows; Windows NT 6.1; rv:2.0b3pre) Gecko/20100730 Minefield/4.0b3pre
Build Identifier: Mozilla/5.0 (Windows; Windows NT 6.1; rv:2.0b3pre) Gecko/20100730 Minefield/4.0b3pre

Accessing fullscreen via alt, view, fullscreen or via F11 while the animation for fullscreen happens the tabs turn to dark grey and the top of the window gets black. 

Reproducible: Always

Steps to Reproduce:
1. Press F11 or Alt>View>Fullscreen

Actual Results:  
While the animation for fullscreen happens the tabs turn to dark grey and the top of the window gets black. 

Expected Results:  
While the animation for fullscreen happens the tabs the top of the window should remain the same color.

Comment 2

[Marcia Knous [:marcia - needinfo? me]]

I can reproduce this as well using  Mozilla/5.0 (Windows; Windows NT 6.1; WOW64; rv:2.0b3) Gecko/20100805 Firefox/4.0b3. Nominating and we will need to find a regression range.

Comment 3

[Aaron Train [:aaronmt]]

Attachment: 4.0b3pre - Grey tab bar (Windows 7)

Comment 4

[Alice0775 White]

Regression window pushlog:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=94f92b34e535&tochange=f0c025ec62c9

Comment 5

[Jim Mathies [:jimm]]

(In reply to comment #3)
> Created attachment 464124 [details]
> 4.0b3pre - Grey tab bar (Windows 7)

This is by design.

(In reply to comment #0)
> User-Agent:       Mozilla/5.0 (Windows; Windows NT 6.1; rv:2.0b3pre)
> Gecko/20100730 Minefield/4.0b3pre
> Build Identifier: Mozilla/5.0 (Windows; Windows NT 6.1; rv:2.0b3pre)
> Gecko/20100730 Minefield/4.0b3pre
> 
> Accessing fullscreen via alt, view, fullscreen or via F11 while the animation
> for fullscreen happens the tabs turn to dark grey and the top of the window
> gets black. 
> 
> Reproducible: Always
> 
> Steps to Reproduce:
> 1. Press F11 or Alt>View>Fullscreen
> 
> Actual Results:  
> While the animation for fullscreen happens the tabs turn to dark grey and the
> top of the window gets black. 
> 
> Expected Results:  
> While the animation for fullscreen happens the tabs the top of the window
> should remain the same color.

I see a little bit of black across the top before the fx button hides. Is this what you're referring to? Seems like we just need to hide the fx button sooner if that's the case.

Comment 6

[Jim Mathies [:jimm]]

Attachment: fullscreen transition

This is what I'm seeing on my display. This is the top of the window right after going to full screen, and I've chopped it up into four section, from left (top) to far right (bottom).

The black area coincides with glass areas on the normalized window that haven't  repainted yet. The fx button is obviously still visible.

We need to better sync the transition to full screen ui with enabling the full screen window.

Comment 7

[Alice0775 White]

(In reply to comment #5)
> (In reply to comment #3)
> > Created attachment 464124 [details] [details]
> > 4.0b3pre - Grey tab bar (Windows 7)
> 
> This is by design.

So, Comment #4 should be ignored

Comment 8

[Gabriela [:gaby2300]]

Attachment: All the tabs turn dark grey

Comment 9

[Jim Mathies [:jimm]]

(In reply to comment #8)
> Created attachment 464164 [details]
> All the tabs turn dark grey

The inactive tabs turn dark grey, the foreground tab is colored normally. I believe this is the desired effect for background tabs.

Comment 10

[Gabriela [:gaby2300]]

(In reply to comment #9)

I don't think so, the background tabs should remain the same color as before

Comment 11

[Gabriela [:gaby2300]]

In reply to comment #5

I'm afraid your first screenshot does not show my issue.

In my case while the animation for fullscreen happens all the tabs turn to dark grey (see my screenshot in comment  #8) and the top of the window gets black. 

Maybe hiding the fx button sooner would stop the issue from showing but will this stop all the tabs turning dark grey or the top of the window turning black?

I mean, do we want to just hide the issue or do we want to solve it?

Comment 12

[Jim Mathies [:jimm]]

(In reply to comment #11)
> In reply to comment #5
> 
> I'm afraid your first screenshot does not show my issue.
> 
> In my case while the animation for fullscreen happens all the tabs turn to dark
> grey (see my screenshot in comment  #8) and the top of the window gets black. 
> 
> Maybe hiding the fx button sooner would stop the issue from showing but will
> this stop all the tabs turning dark grey or the top of the window turning
> black?
> 
> I mean, do we want to just hide the issue or do we want to solve it?

I don't understand the problem. If this is what you see in full screen mode:

(In reply to comment #8)
> Created attachment 464164 [details]
> All the tabs turn dark grey

That's correct behavior. You mention "animation", but I'm not sure how that plays into what you've posted an image of. Is this screenshot after we transition, during?

Comment 13

[Jim Mathies [:jimm]]

Attachment: tabs on bottom

Comment 14

[Jim Mathies [:jimm]]

I think the animation you're referring to the fold up of the ui. If that's the case, with tabs on top, the black background is expected.

Comment 15

[Jim Mathies [:jimm]]

-> theme / ux folks for resolution

Comment 16

[Gabriela [:gaby2300]]

(In reply to comment #12

The screenshot is during transition to fullscreen.

(In reply to comment #14)

If the black background is expected, then it's fine.
Is all the tabs turning dark grey during the transition expected too?
If so, why has Marcia Knous made comment #2?

Comment 17

[Mike Beltzner [:beltzner, not reading bugmail]]

team UX: the issue seems to be what happens when the UI "rolls up" in full screen mode with auto-hide (is that correct, Gabriela and Jimm?)

What should the background colour be there?

Comment 18

[Mike Beltzner [:beltzner, not reading bugmail]]

Removing blocking flag until we get an answer.

Comment 19

[Stephen Horlander [:shorlander] (If you're waiting on a response please ping me on Slack or IRC)]

The grey color is intended in fullscreen. I think the actual problem here is the choppiness of the transition which seems to go from black to the final grey color.

Comment 20

[Jim Mathies [:jimm]]

(In reply to comment #19)
> The grey color is intended in fullscreen. I think the actual problem here is
> the choppiness of the transition which seems to go from black to the final grey
> color.

The black glass is another issue. The poster felt the gray color we've chosen for the tab area was incorrect. If that's intended, we can either morph this into the glass transition bug, or resolve wontfix.

Comment 21

[Zhenshuo Fang (:fang) - Firefox UX Team]

(In reply to Jim Mathies [:jimm] from comment #20)
> (In reply to comment #19)
> > The grey color is intended in fullscreen. I think the actual problem here is
> > the choppiness of the transition which seems to go from black to the final grey
> > color.
> 
> The black glass is another issue. The poster felt the gray color we've
> chosen for the tab area was incorrect. If that's intended, we can either
> morph this into the glass transition bug, or resolve wontfix.

Mark as wontfix for now.