58345 - if ~/.netscape/"old history.dat" exists, we fail to rename history.dat and we corrupt history

Status: RESOLVED WONTFIX

(MailNews Core :: Profile Migration, defect, P3)

Description

[Boris Zbarsky [:bzbarsky]]

Linux all trunk builds for the last few months up to and including 2000102708.

When I migrate my Netscape 4.x profile, I get the messages:

Inside Migrate Profile routine.
start of pref migration
failed to migrate properly.  err=-2147418113

The resulting migrated profile has a corrupt history.dat.  This is manifested as
follows:  The history window is empty, and links are not marked as followed.

The only way to fix the problem that I have found is to remove Mozilla's
history.dat.  After that things work fine.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: My netscape 4.x history.dat file

Comment 2

[(not reading, please use [e-mail] instead)]

in nsPrefMigration.cpp, DoSpecialUpdates() is supposed to move the 4.x history
file out of the way.  it should be moving it to "old history.dat"

question:  do you have a "old history.dat" file in your .netscape directory?

that may cause this problem.  (I'll try on my build.)

also, if migration fails before we call DoSpecialUpdates() we won't move that
file to the side.

dbragg, we should probably be removing the 4.x history file in
DoSpecialUpdates(), instead of renaming it.

I'll attach a patch.

Comment 3

[(not reading, please use [e-mail] instead)]

boris, can you check your .netscape directory?

if you don't already have an "old history.dat" file in .netscape, my guess is
migration is failing for you in other ways.

we can work on figuring that out.

Comment 4

[(not reading, please use [e-mail] instead)]

here's a patch to fix the problem if "old history.dat" exists in the profile
directory.

Comment 5

[(not reading, please use [e-mail] instead)]

Attachment: fix

Comment 6

[Boris Zbarsky [:bzbarsky]]

There is no "old history.dat" in my .netscape directory.

Migration also does not migrate mailnews preferences at all, so I am guessing
that there is a failure somewhere before migration gets to that.

Comment 7

[(not reading, please use [e-mail] instead)]

ok, let me change this bug into the bug where we fail if "old history.dat"
exists.  (since the attached patch will fix that bug.)

can you send me your 4.x prefs.js file so I can try to reproduce your migration
failure?

the "old history.dat" file is not rtm, removing keywords.

Comment 8

[(not reading, please use [e-mail] instead)]

migration bugs to racham

Comment 9

[(not reading, please use [e-mail] instead)]

mass re-assign.

Comment 10

[(not reading, please use [e-mail] instead)]

sorry for the spam.  making bugzilla reflect reality as I'm not working on these bugs.  filter on FOOBARCHEESE to remove these in bulk.

Comment 11

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

NS4.x migration bug. We don't support that in Shredder trunk builds anymore, do we?

Comment 12

[David :Bienvenu]

no, we don't - marking wontfix.