Closed Bug 583543 Opened 14 years ago Closed 14 years ago

Exclude additional mass-ping IPs

Categories

(Camino Graveyard :: General, defect)

x86
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: alqahira, Assigned: alqahira)

Details

Attachments

(1 file)

Attached patch More exclusionsSplinter Review
These newly-added IPs generate 4K, 25K, or 55K pings/day when they choose to ping (which, thankfully, is not all that often).

3 more related IPs from Australia (25K or 55K), Brazil guy Mk II (4K), and Brooklyn, CT (25K).

Nebraska is only generating ~500 pings/day across all their IPs when they report in, so I didn't include them in this patch.
Attachment #461856 - Flags: review?(samuel.sidler)
Brooklyn also did "more sensible" 4K and (K days in early June. :P
Comment on attachment 461856 [details] [diff] [review]
More exclusions

>diff --git a/tools/stats/generate_update_statistics b/tools/stats/generate_update_statistics
>+badips="204.234.28.|149.150.236.250|203.42.177.[16-19]|200.19.92.|189.108.14.138|72.10.105.23"

1) Is it worth just putting "203.42.177." in the list? Do we get legit pings from the other 252 IPs in that range?
2) Generally, anything over 5 pings is suspect, but if they're consistent and not malformed, we can include them.

Otherwise, r=me.
Attachment #461856 - Flags: review?(samuel.sidler) → review+
Actually, doing a |host| on 203.42.177.[1-255], I think the bad IPs will only fall between .11 and .19.
Nebraska's pings are mostly malformed, so I'll add those IPs.

I'd rather not block entire subnets unless it's warranted, nor even "related IPs" unless they're really spamming us (especially with bad pings).  I'll see what sort of hits we get from .11 to .15, though.
http://hg.mozilla.org/camino/rev/ea231e18fbc5 including the bad Nebraska IPs (though they seem to have gotten much better lately).  I saw no pings since April from Australia's .11 to .15, so I didn't block them.
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: