All users were logged out of Bugzilla on October 13th, 2018

Value sanitizing algorithm form <input type='url'>

RESOLVED FIXED in mozilla2.0b5

Status

()

RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: mounir, Assigned: mounir)

Tracking

(Blocks: 2 bugs, {dev-doc-complete, html5})

Trunk
mozilla2.0b5
dev-doc-complete, html5
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment)

(Assignee)

Description

8 years ago
Value sanitizing algorithm came with bug 549475
input type url is going to come with bug 344615
(Assignee)

Comment 1

8 years ago
Created attachment 461907 [details] [diff] [review]
Patch v1
Attachment #461907 - Flags: superreview?(jst)
Attachment #461907 - Flags: review?(Olli.Pettay)

Comment 2

8 years ago
Comment on attachment 461907 [details] [diff] [review]
Patch v1


>-  const nsAString& for_str = nsContentUtils::TrimWhitespace(forAttr);
>+  const nsAString& for_str =
>+    nsContentUtils::TrimWhitespace<nsCRT::IsAsciiSpace>(forAttr);

Could you file a followup bug to check whether all the places where TrimWhitespace<nsCRT::IsAsciiSpace>
is used, really should use it and not TrimWhitespace<nsContentUtils::IsHTMLWhitespace>.
Attachment #461907 - Flags: review?(Olli.Pettay) → review+
(Assignee)

Updated

8 years ago
Blocks: 583775

Updated

8 years ago
Attachment #461907 - Flags: superreview?(jst) → superreview+
(Assignee)

Comment 3

8 years ago
This is now in the tree:
rev: http://hg.mozilla.org/mozilla-central/rev/03367932ad41
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Flags: in-testsuite+
Keywords: dev-doc-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b5
Keywords: dev-doc-needed → dev-doc-complete
You need to log in before you can comment on or make changes to this bug.