Closed
Bug 583610
Opened 15 years ago
Closed 14 years ago
Value sanitizing algorithm form <input type='url'>
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla2.0b5
People
(Reporter: mounir, Assigned: mounir)
References
(Blocks 1 open bug, )
Details
(Keywords: dev-doc-complete, html5)
Attachments
(1 file)
|
9.86 KB,
patch
|
smaug
:
review+
jst
:
superreview+
|
Details | Diff | Splinter Review |
Value sanitizing algorithm came with bug 549475
input type url is going to come with bug 344615
|
Assignee | |
Comment 1•15 years ago
|
||
Attachment #461907 -
Flags: superreview?(jst)
Attachment #461907 -
Flags: review?(Olli.Pettay)
|
||
Comment 2•15 years ago
|
||
Comment on attachment 461907 [details] [diff] [review]
Patch v1
>- const nsAString& for_str = nsContentUtils::TrimWhitespace(forAttr);
>+ const nsAString& for_str =
>+ nsContentUtils::TrimWhitespace<nsCRT::IsAsciiSpace>(forAttr);
Could you file a followup bug to check whether all the places where TrimWhitespace<nsCRT::IsAsciiSpace>
is used, really should use it and not TrimWhitespace<nsContentUtils::IsHTMLWhitespace>.
Attachment #461907 -
Flags: review?(Olli.Pettay) → review+
|
||
Updated•15 years ago
|
Attachment #461907 -
Flags: superreview?(jst) → superreview+
|
|
Assignee | |
Comment 3•14 years ago
|
||
This is now in the tree:
rev: http://hg.mozilla.org/mozilla-central/rev/03367932ad41
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Flags: in-testsuite+
Keywords: dev-doc-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b5
|
||
Updated•14 years ago
|
Keywords: dev-doc-needed → dev-doc-complete
You need to log in
before you can comment on or make changes to this bug.
Description
•