583710 - Date picker returns dates in English format breaking advanced search on localized pages

Status: RESOLVED FIXED

(Input Graveyard :: Frontend, defect)

Description

[Francesco Lodolo [:flod]]

Suppose you want to search results from Aug 1st to Aug 2nd on the Italian page.

Italian dates are in the dd/mm/aaaa format, so Aug 1st is 01/08/2010. If I pick the date using the date picker, the result displayed in the date field is 08/01/2010 (which is Jan 8th in Italian).

This is the resulting URL, the query has obviously no results (from Jan 8th to Feb 8th).

http://input.mozilla.com/it/search/?product=firefox&date_start=08%2F01%2F2010&date_end=08%2F02%2F2010

Comment 1

[Fred Wenzel [:wenzel]]

Looks like the date picker supports L10n by importing an additional JS file according to the locale: http://jqueryui.com/demos/datepicker/ (towards the bottom).

That's not the smoothest way of fixing this, and it does not seem to be available for all our locales, so I am unsure if that's the way to go.

Comment 2

[Dave Dash [:davedash, :dd] (assign all bugs to mbrandt)]

(In reply to comment #1)
> Looks like the date picker supports L10n by importing
> an additional JS file according to the locale:
> http://jqueryui.com/demos/datepicker/ (towards the bottom).
> 
> That's not the smoothest way of fixing this, and it does not seem to be
> available for all our locales, so I am unsure if that's the way to go.

It sounds like the datepicker is being too smart?  Since it's re-interpreting the results?

Assigning to James.  


James I think it'd be best if all the urls were the same regardless of locale.

Comment 3

[Dave Dash [:davedash, :dd] (assign all bugs to mbrandt)]

Clearing out 4.2

Comment 4

[Nigel Babu [:nigelb]]

I see two trains of thought on fixing this

- leave as is, so that there is no complications with search.
- use the datepicker's L10n.

What's the way forward so that I ca work on it?

Comment 5

[Dave Dash [:davedash, :dd] (assign all bugs to mbrandt)]

If we use datepicker's what does that do?

I select July 4 in fr locale and that gives 4/7/2011?

If so that sounds right, but then we need to make sure we handle it right in the search code (convert it properly to what sphinx expects).

I'd go that route - and supply some decent tests to verify we're doing this correctly.

Comment 6

[Dave Dash [:davedash, :dd] (assign all bugs to mbrandt)]

Looking at production now this seems fine.

The URLS all use YYYY-MM-DD format as does the dates listed.