Closed Bug 583828 Opened 10 years ago Closed 10 years ago
Wrong zoom level calculation in _get
Zoom Rect For Rect
The old version of this code (_getZoomLevelForElement) called browserToViewportRect on the element's bounding rect, so it needed to multiply vis.width by bv.getZoomLevel() too. The new code no longer calls browserToViewportRect, so it should no longer apply the getZoomLevel factor.
Also clean up some nearby whitespace.
There are several places where getZoomLevelForRect are called: http://mxr.mozilla.org/mobile-browser/search?string=getZoomLevelForRect It looks like FormHelper still seems to do things in viewport coordinates?
(In reply to comment #2) > There are several places where getZoomLevelForRect are called: > http://mxr.mozilla.org/mobile-browser/search?string=getZoomLevelForRect > > It looks like FormHelper still seems to do things in viewport coordinates? Good catch. Fixed.
Attachment #462167 - Flags: review?(webapps) → review+
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.