583847 - Weave should be using createAsyncStatement instead of createStatement

Status: RESOLVED FIXED

(Firefox :: Sync, defect)

Description

[Shawn Wilsher :sdwilsh]

Weave should be using createAsyncStatement instead of createStatement whenever possible (like whenever you only call executeAsync with the statement).  This will not acquire any SQLite or storage locks on the calling thread (in this case, the main thread).  Less locking means less chances of hanging.

Comment 1

[Philipp von Weitershausen [:philikon]]

According to sdwilsh createAsyncStatement is only available in Gecko 2.0, though, we'll have to keep the old way on Firefox 3.5/3.6.

Comment 2

[Philipp von Weitershausen [:philikon]]

Attachment: v1

Use createAsyncStatement everywhere. Converted frecency query in BookmarksStore to async as well.

Comment 3

[Philipp von Weitershausen [:philikon]]

1.4.x: http://hg.mozilla.org/services/fx-sync/rev/57fa3a74fc3a
default: http://hg.mozilla.org/services/fx-sync/rev/7e8b1f7852a9