Closed
Bug 584026
Opened 14 years ago
Closed 14 years ago
Fork abCardOverlay.xul
Categories
(MailNews Core :: Address Book, defect)
MailNews Core
Address Book
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 3.3a1
People
(Reporter: standard8, Assigned: standard8)
References
Details
Attachments
(1 file)
|
3.09 KB,
patch
|
mnyromyr
:
review+
Bienvenu
:
superreview+
|
Details | Diff | Splinter Review |
I think we should fork abCardOverlay.xul. The abCardOverlay.js and abCommon.js files are already forked between the two apps.
The issue is that if we do any changes it, we're forcing developers to port those changes to the other application, or wait for other people to do the port. Therefore I'd rather just separate this file so that it matches what we've got in javascript land.
Attachment #462382 -
Flags: superreview?(bienvenu)
Attachment #462382 -
Flags: review?(mnyromyr)
|
||
Updated•14 years ago
|
Attachment #462382 -
Flags: superreview?(bienvenu) → superreview+
|
||
Comment 1•14 years ago
|
||
Do you have something special in mind?
I mean, abCardOverlay.js could even resynced?
|
|
||
Comment 3•14 years ago
|
||
Comment on attachment 462382 [details] [diff] [review]
The fix
Jim, you got point there.
Attachment #462382 -
Flags: review?(mnyromyr) → review+
|
Assignee | |
Comment 4•14 years ago
|
||
(In reply to comment #1)
> Do you have something special in mind?
> I mean, abCardOverlay.js could even resynced?
Sorry, I meant to respond earlier. Jim's bug was the one we had in mind.
Whilst I think abCardOverlay.js could be re-united, I believe that we've accepted in the past that the UIs may generally diverge.
|
|
Assignee | |
Comment 5•14 years ago
|
||
Status: NEW → RESOLVED
Closed: 14 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 3.2a1
You need to log in
before you can comment on or make changes to this bug.
Description
•