584340 - nsIXMLHttpRequest.statusText in Blocklist.prototype.onXMLError

Status: RESOLVED FIXED

(Toolkit :: Safe Browsing, defect)

Description

[timeless]

Error: [Exception... "Component returned failure code: 0x80040111 (NS_ERROR_NOT_AVAILABLE) [nsIXMLHttpRequest.statusText]"  nsresult: "0x80040111 (NS_ERROR_NOT_AVAILABLE)"  location: "JS frame :: file:///C:/build/dbg-firefox-i686-pc-mingw32/dist/bin/components/nsBlocklistService.js :: anonymous :: line 470"  data: no]
Source File: file:///C:/build/dbg-firefox-i686-pc-mingw32/dist/bin/components/nsBlocklistService.js

This should either be guarded by some other value or just stuck in a try block.

It happens to me because my network isn't really up.

Comment 1

[timeless]

Attachment: patch

Comment 2

[Robert Strong (they/them - no direct email)]

Comment on attachment 463327 [details] [diff] [review]
patch

>diff --git a/toolkit/mozapps/extensions/nsBlocklistService.js b/toolkit/mozapps/extensions/nsBlocklistService.js
>--- a/toolkit/mozapps/extensions/nsBlocklistService.js
>+++ b/toolkit/mozapps/extensions/nsBlocklistService.js
>@@ -512,10 +512,14 @@ Blocklist.prototype = {
>       request = aEvent.target.channel.QueryInterface(Ci.nsIRequest);
>       status = request.status;
>     }
>-    var statusText = request.statusText;
>+    var statusText = "nsIXMLHttpRequest channel unavailable";
>     // When status is 0 we don't have a valid channel.
>-    if (status == 0)
>-      statusText = "nsIXMLHttpRequest channel unavailable";
>+    if (status != 0) {
>+      try {
>+        let requestStatusText = request.statusText;
>+        statusText = requestStatusText;
You should be able to just do
statusText = request.statusText;

r=me with that

Comment 3

[Reed Loden [:reed]]

Comment on attachment 463327 [details] [diff] [review]
patch

>+    if (status != 0) {
>+      try {
>+        let requestStatusText = request.statusText;
>+        statusText = requestStatusText;
>+      } catch (e) {
>+    }

Missing a '}'.

Comment 4

[timeless]

Attachment: without let

Comment 5

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 463526 [details] [diff] [review]
without let

a=beltzner, zero risk

Comment 6

[Marco Bonardo [:mak]]

http://hg.mozilla.org/mozilla-central/rev/de4b86b6c74d