TextRunWordCache::MakeTextRun doesn't null check new [] result

RESOLVED FIXED

Status

()

Core
Layout: Text
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: smaug, Assigned: Ehsan)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(status1.9.2 .9-fixed, status1.9.1 .12-fixed)

Details

(Whiteboard: [sg:critical?])

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

7 years ago
This *might* be the reason for bug 583077, at least on branches.
Created attachment 462788 [details] [diff] [review]
Patch (v1)

But shouldn't operator new[] been infallible?
Assignee: nobody → ehsan
Status: NEW → ASSIGNED
Attachment #462788 - Flags: review?(roc)
(Reporter)

Comment 2

7 years ago
On trunk yes, but not on branches.
Ah, yes.  I missed the branch mention for some reason.  Then I guess we only need to take this patch on branches.
Created attachment 462949 [details] [diff] [review]
Patch (v1)

The typos that I make sometimes amaze me...
Attachment #462788 - Attachment is obsolete: true
Attachment #462949 - Flags: review?(roc)
Attachment #462788 - Flags: review?(roc)
Attachment #462949 - Flags: review?(roc) → review+
Comment on attachment 462949 [details] [diff] [review]
Patch (v1)

This bug only affects branches, so I'm asking approval only for branches.
Attachment #462949 - Flags: approval1.9.2.9?
Attachment #462949 - Flags: approval1.9.1.12?
Comment on attachment 462949 [details] [diff] [review]
Patch (v1)

Approved for 1.9.2.9 and 1.9.1.12, a=dveditz for release-drivers
Attachment #462949 - Flags: approval1.9.2.9?
Attachment #462949 - Flags: approval1.9.2.9+
Attachment #462949 - Flags: approval1.9.1.12?
Attachment #462949 - Flags: approval1.9.1.12+
OS: Mac OS X → All
Hardware: x86 → All
Whiteboard: [sg:critical?]
http://hg.mozilla.org/releases/mozilla-1.9.2/rev/74b1c75a67a2
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/a276f3e7f3dd
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
status1.9.1: --- → .12-fixed
status1.9.2: --- → .9-fixed
Resolution: --- → FIXED
Group: core-security
You need to log in before you can comment on or make changes to this bug.