Closed Bug 584357 Opened 14 years ago Closed 14 years ago

TextRunWordCache::MakeTextRun doesn't null check new [] result

Categories

(Core :: Layout: Text and Fonts, defect)

Product:
Core
Component:
Layout: Text and Fonts
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Tracking Flags:
Tracking Status
status1.9.2 --- .9-fixed
status1.9.1 --- .12-fixed

People

(Reporter: smaug, Assigned: ehsan.akhgari)

Details

(Whiteboard: [sg:critical?])

Attachments

(1 file, 1 obsolete file)

Patch (v1)
2.60 KB, patch
roc
: review+
dveditz
: approval1.9.2.9+
dveditz
: approval1.9.1.12+
Details | Diff | Splinter Review 
This *might* be the reason for bug 583077, at least on branches.
Attached patch Patch (v1) (obsolete) — — Splinter Review 
But shouldn't operator new[] been infallible?
Assignee: nobody → ehsan
Status: NEW → ASSIGNED
Attachment #462788 - Flags: review?(roc)
On trunk yes, but not on branches.
Ah, yes.  I missed the branch mention for some reason.  Then I guess we only need to take this patch on branches.
Attached patch Patch (v1) — — Splinter Review 
The typos that I make sometimes amaze me...
Attachment #462788 - Attachment is obsolete: true
Attachment #462949 - Flags: review?(roc)
Attachment #462788 - Flags: review?(roc)
Comment on attachment 462949 [details] [diff] [review]
Patch (v1)

This bug only affects branches, so I'm asking approval only for branches.
Attachment #462949 - Flags: approval1.9.2.9?
Attachment #462949 - Flags: approval1.9.1.12?
Comment on attachment 462949 [details] [diff] [review]
Patch (v1)

Approved for 1.9.2.9 and 1.9.1.12, a=dveditz for release-drivers
Attachment #462949 - Flags: approval1.9.2.9?
Attachment #462949 - Flags: approval1.9.2.9+
Attachment #462949 - Flags: approval1.9.1.12?
Attachment #462949 - Flags: approval1.9.1.12+
OS: Mac OS X → All
Hardware: x86 → All
Whiteboard: [sg:critical?]
Group: core-security
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: