584523 - shouldn't try to fetch audio parts inline

Status: RESOLVED FIXED

(MailNews Core :: Networking: IMAP, defect)

Description

[David :Bienvenu]

Attachment: proposed fix

When doing mime parts on demand, we should leave audio parts (e.g., mp3 files) on the imap server. There are other parts/types we should leave on the server, but application/* catches most of them, and audio catches an other source of big files.

Comment 1

[Phil Lacy]

Comment on attachment 462946 [details] [diff] [review]
proposed fix

>+    if (!PL_strcasecmp(m_bodyType, "AUDIO"))
>+      return PR_FALSE;
>     // Here's where we can add some more intelligence -- let's leave out
>     // any other parts that we know we can't display inline.

shouldn't the added intelligence be after this comment, not under the 'application' comment

Comment 2

[David :Bienvenu]

(In reply to comment #1)

> >+    if (!PL_strcasecmp(m_bodyType, "AUDIO"))
> >+      return PR_FALSE;
> >     // Here's where we can add some more intelligence -- let's leave out
> >     // any other parts that we know we can't display inline.
> 
> shouldn't the added intelligence be after this comment, not under the
> 'application' comment

No, I read the comment to mean "this is where you'd add other types of parts we can't display inline, in addition to what the code already handles."

Comment 3

[David :Bienvenu]

fixed on trunk. This won't affect users who have offline set on their folders, but I ran across this while testing some other stuff and it's a trivial fix.