58454 - NNTP is sending two similar XOVER

Status: RESOLVED INVALID

(MailNews Core :: Networking: NNTP, defect, P3)

Description

[Henrik Gemal]

If you log NNTP you'll get something like this in your log:
0[3460f0]: Chunk will be (6330-6364)
0[3460f0]: Next state: NNTP_XOVER_SEND
0[3460f0]: XOVER 6330-6364
0[3460f0]: Sending: XOVER 6330-6364
0[3460f0]: Sending: XOVER 6330-6364
0[3460f0]: Next state: NNTP_RESPONSE
0[3460f0]: Receiving: 224 data follows

Why are we sending two XOVER commands that are the same?

Comment 1

[[e-mail] (gone - use [e-mail] instead)]

Mass moving all NEWS bugs from esther to myself.

Comment 2

[Håkan Waara]

Seth, what is the XOVER command doing? Is it supposed to be called twice?

Thanks

Comment 3

[(not reading, please use [e-mail] instead)]

good news, we aren't sending XOVER twice.  we are just logging it twice.

there is an extra call to NNTP_LOG_WRITE() in nsNNTPProtocol::XoverSend()

I'll remove it after the mailnews performance branch lands.

Comment 4

[(not reading, please use [e-mail] instead)]

fixed.

Comment 5

[[e-mail] (gone - use [e-mail] instead)]

Attachment: My new logfile, build 2001032304.

Comment 6

[[e-mail] (gone - use [e-mail] instead)]

Looks good to me:

0[2f4470]: Next state: NNTP_XOVER_BEGIN
0[2f4470]: SetCurrentGroup to netscape.public.mozilla.mail-news
0[2f4470]: Next state: NNTP_FIGURE_NEXT_CHUNK
0[2f4470]: Next state: NEWS_PROCESS_XOVER

Verified fixed.

Comment 7

[Henrik Gemal]

with build 20010328:
0[346138]: CleanupAfterRunningUrl()
0[346138]: ParseURL
0[346138]: fullPath = /pe.indernet
0[346138]: m_messageID = (null)
0[346138]: group = pe.indernet
0[346138]: commandSpecificData = (null)
0[346138]: m_key = -1
0[346138]: Next state: SEND_FIRST_NNTP_COMMAND
0[346138]: Sending: GROUP pe.indernet
0[346138]: Next state: NNTP_RESPONSE
0[346138]: Receiving: 211 613 486 1121 pe.indernet
0[346138]: Next state: SEND_FIRST_NNTP_COMMAND_RESPONSE
0[346138]: Next state: SETUP_NEWS_STREAM
0[346138]: Next state: NNTP_XOVER_BEGIN
0[346138]: SetCurrentGroup to pe.indernet
0[346138]: Next state: NNTP_FIGURE_NEXT_CHUNK
0[346138]: Chunk will be (1109-1121)
0[346138]: Next state: NNTP_XOVER_SEND
0[346138]: Sending: XOVER 1109-1121
0[346138]: Sending: XOVER 1109-1121
0[346138]: Next state: NNTP_RESPONSE
0[346138]: Receiving: 480 Authentication required for command

Comment 8

[Håkan Waara]

Gemal or Stephend: is this still happening when you guys log the output?

Comment 9

[Henrik Gemal]

I'm not sure we're actully sending the two XOVER commands, but the NNTP log
STILL say that we are...

build 20011016

Comment 10

[Peter Janes]

I see similar behaviour, immediately before mailnews header download freezes
(which might be bug 84042):

1024[8087020]: (8117a68) SetCurrentGroup to netscape.public.mozilla.mail-news
1024[8087020]: (8117a68) Next state: NNTP_FIGURE_NEXT_CHUNK
1024[8087020]: (8117a68) Chunk will be (18994-19043)
1024[8087020]: (8117a68) Next state: NNTP_XOVER_SEND
1024[8087020]: (8117a68) Sending: XOVER 18994-19043
1024[8087020]: (8117a68) Sending: XOVER 18994-19043

Linux -sea trunk build 2002010708.

Comment 11

[(not reading, please use [e-mail] instead)]

sorry for the spam.  making bugzilla reflect reality as I'm not working on these bugs.  filter on FOOBARCHEESE to remove these in bulk.

Comment 12

[Joshua Cranmer [:jcranmer]]

It doesn't send it twice. The log just prints it out twice. Will be fixed as part of bug 400331 -> RESO INVAL