58462 - OS/2 - Mozilla doesn't recognize plugins

Status: VERIFIED FIXED

(Core Graveyard :: Plug-ins, defect, P3)

Description

[achimha]

Copying the npswf2.dll (Flash Player for OS/2) to bin\plugins or bin\components
does not cause Mozilla to recognize the plugin. This worked fine before with
older Warpzilla builds (around M16). Don't know if Plugins are broken cross
platform or OS/2 only (I promise to install M18 under Win32 ASAP and verify my
reports before submitting them...)

Comment 1

[shrirang khanzode]

Works fine on linux/mac.windows(10/28 br builds). Seems Os/2 specific.

Comment 2

[slaquinta]

SCREENED.  VERIFIED AS VALID.

Comment 3

[Mike Kaply [:mkaply]]

Various calling convention problems.

This bug:

http://bugzilla.mozilla.org/show_bug.cgi?id=58491

Is the bulk of the problem.

I will also attach other fixes.

Comment 4

[Mike Kaply [:mkaply]]

Attachment: Missing OS/2 callback types in nscom.h

Comment 5

[Mike Kaply [:mkaply]]

Attachment: Wrong use of variant, not setting filename

Comment 6

[Mike Kaply [:mkaply]]

Attachment: OS/2 needs events too

Comment 7

[Doug Turner (:dougt)]

r=dougt on attachment 18307 [details] [diff] [review]

Comment 8

[av (gone)]

r=av on changes to ns4xPliginInstance.cpp and nsPluginsDirOS2.cpp

Comment 9

[Mike Kaply [:mkaply]]

Attachment: Take the XP_WIN path for OS/2

Comment 10

[Chris Waterson]

nsCom.h patch looks good to me. sr=waterson

Comment 11

[av (gone)]

The last change will probably be not needed because of bug 57885.

Comment 12

[achimha]

Warpzilla nightly build from 11/08 causes a crash in the Flash
plugin (legacy plugin) whenever Warpzilla tries to load it
(about:plugins or <embed>).

Comment 13

[Mike Kaply [:mkaply]]

Fixes checked in. Hurrah

Comment 14

[shrirang khanzode]

qa: [e-mail]. Pls verify this bug since I do not have the setup.Thx.

Comment 15

[achimha]

works fine now, opened new bug for different plugin problem though, bug can be 
closed