Closed Bug 584667 Opened 14 years ago Closed 14 years ago

"Unsorted Bookmarks" icon missing in bookmarks button menu

Categories

(Firefox :: Theme, defect)

Product:
Firefox
Component:
Theme
Platform:
All
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 4.0b4
Tracking Flags:
Tracking Status
blocking2.0 --- beta4+

People

(Reporter: mstange, Assigned: mstange)

References

Details

Attachments

(3 files, 1 obsolete file)

screenshot (by Mehmet Sahin)
116.10 KB, image/png
Details
Missing Flag in Bookmarks Button Menu when Sidebar is active
167.19 KB, image/png
Details
for checkin
1.07 KB, patch
Details | Diff | Splinter Review
No description provided.
blocking2.0: --- → ?
Attached patch v1 (obsolete) — — Splinter Review
The icon has a different name in pinstripe.
Attachment #463109 - Flags: review?(dao)
Attachment #463109 - Flags: review?(dao) → review+
Attachment #463109 - Flags: approval2.0?
blocking2.0: ? → beta4+
Attachment #463109 - Flags: approval2.0?
The Flag for the Sidebar in the Bookmarks Button Menu is also missing when it is active. See enclosed screenshot. Thanks and regards Mehmet
Markus - do you plan on landing your patch? We need it in by the end of the day Friday. If you can't get it landed yourself, please add checkin-needed while keeping in mind the points raised in http://blog.bonardo.net/2010/06/22/so-youre-about-to-use-checkin-needed
Oh, I almost forgot about this. I'll land it now.
Attached patch for checkin — — Splinter Review
I'll let somebody else check this in together with his patches so that I don't waste Tinderbox bandwidth.
Attachment #463109 - Attachment is obsolete: true
Keywords: checkin-needed
http://hg.mozilla.org/mozilla-central/rev/4b75be253a5a
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 4.0b4
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: