Make Modern work nicely with places bookmarks work

RESOLVED FIXED in seamonkey2.1a3

Status

SeaMonkey
Themes
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: Robert Kaiser, Assigned: Robert Kaiser)

Tracking

({modern})

Trunk
seamonkey2.1a3
modern
Dependency tree / graph

Firefox Tracking Flags

(blocking-seamonkey2.1 a3+)

Details

Attachments

(1 attachment)

(Assignee)

Description

7 years ago
Bug 580660 at least, maybe other places bookmarks work, introduces some Classic theme changes that should be ported in a reasonable way to Modern.
(Assignee)

Updated

7 years ago
Keywords: modern
Target Milestone: --- → seamonkey2.1a3
(Assignee)

Comment 1

7 years ago
Created attachment 463952 [details] [diff] [review]
v1: Modern changes for places bookmarks

Here's a patch that should get everything my places bookmarks patches do to modern. The Classic parts matching this are done in bug 580660 and bug 580662. I copied the icons from there and modified them to match the Modern color scheme as well as I could.
Assignee: nobody → kairo
Status: NEW → ASSIGNED
Attachment #463952 - Flags: review?(neil)
(Assignee)

Updated

7 years ago
blocking-seamonkey2.1: --- → ?

Comment 2

7 years ago
We should be trying to at least match classic for a3, so blocking for the moment.
blocking-seamonkey2.1: ? → a3+
Version: unspecified → Trunk

Comment 3

7 years ago
Comment on attachment 463952 [details] [diff] [review]
v1: Modern changes for places bookmarks

Could you make sure either the existing follow-up bugs for classic also cover modern or you have parallel follow-up bugs for modern. Thanks.
Attachment #463952 - Flags: review?(neil) → review+
(Assignee)

Comment 4

7 years ago
(In reply to comment #3)
> Could you make sure either the existing follow-up bugs for classic also cover
> modern or you have parallel follow-up bugs for modern. Thanks.

Sure, my plans are to address both Classic and Modern in sync in bug 585601.
(Assignee)

Comment 5

7 years ago
Pushed the patch as http://hg.mozilla.org/comm-central/rev/f8a85fd368e3
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED

Comment 6

7 years ago
(In reply to comment #4)
> (In reply to comment #3)
> > Could you make sure either the existing follow-up bugs for classic also cover
> > modern or you have parallel follow-up bugs for modern. Thanks.
> Sure, my plans are to address both Classic and Modern in sync in bug 585601.
Any nits will almost certainly apply equally to both themes.
You need to log in before you can comment on or make changes to this bug.