584775 - Switch to addEventListener("error") for the WebConsole error trapping

Status: RESOLVED WONTFIX

(DevTools :: General, defect)

Description

[David Dahl :ddahl]

<sdwilsh> ddahl: why do you guys go and store the original error handler and then call it instead of just doing window.addEventListener("error"...) for your error handler which cannot override the pages?
<ddahl> sdwilsh: i think i followed some advice sayre gave me, but it sounds like it did it wrong
<sdwilsh> ddahl: well, maybe not.  I'm sure both work right, although your code my not be happy if the site's error handler throws
<ddahl> sdwilsh: good point
<sdwilsh> (you won't return false)
<sdwilsh> ddahl: you should probably file a bug about switching to addEventListener
<ddahl> nice
<ddahl> sdwilsh: ok, will do
<sdwilsh> also, if a site changes their error handler ddahl, they'll clobber yours

Comment 1

[Mihai Sucan [:msucan]]

This is no longer a valid bug. We switched away from using the window.onerror hack.