584885 - Redirect forum/6 to questions?tagged=FxHome

Status: VERIFIED FIXED

(support.mozilla.org :: Questions, task)

Description

[Paul Craciunoiu [:paulc]]

After bug 584712 is run, we can safely redirect these old urls over to the questions app.

Comment 1

[Paul Craciunoiu [:paulc]]

Attachment: v1, redirects /forum/6 to /en-US/questions?tagged=FxHome, and threads -> questions

Migrated questions keep the IDs so we can also do the 2nd redirect.

Comment 2

[Erik Rose [:erik][:erikrose]]

Comment on attachment 463332 [details] [diff] [review]
v1, redirects /forum/6 to /en-US/questions?tagged=FxHome, and threads -> questions

I took the liberty of removing some unneeded backslashes, so this is what I actually tested:
RewriteRule ^([-a-zA-Z]+/)?forum/6/?$ /en-US/questions?tagged=FxHome [L,QSA,R=301]
RewriteRule ^([-a-zA-Z]+/)?forum/6(.*) /en-US/questions$2 [L,QSA,R=301]

http://localhost/en-US/forum/66 redirects to http://localhost/en-US/questions6, which is weird.

Comment 3

[Erik Rose [:erik][:erikrose]]

We should also take the QSA out of the first one, as it makes http://localhost/en-US/forum/6?tagged=greeb redirect to http://localhost/en-US/questions?tagged=FxHome&tagged=greeb. (There aren't any querystring chunks we'd want to hang onto between the forums and questions apps, are there?)

Comment 4

[[:Cww]]

(In reply to comment #1)
Not quite, anything added after thursday won't have the same ID after migration.  We're going to have to break links.

Comment 5

[Paul Craciunoiu [:paulc]]

Attachment: v2, minor change

Fixed.

Comment 6

[Paul Craciunoiu [:paulc]]

(In reply to comment #4)
> (In reply to comment #1)
> Not quite, anything added after thursday won't have the same ID after
> migration.  We're going to have to break links.
True. I need to fix that in my migration branch. Sounds like we should just not bother to redirect questions at all, just the forum itself.

Comment 7

[Paul Craciunoiu [:paulc]]

Attachment: v3, only rewrite forum/6

Comment 8

[Paul Craciunoiu [:paulc]]

Committed patch v3, r71958.

Comment 9

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED:

http://support-stage.mozilla.com/en-US/forum/6

GET /en-US/forum/6 HTTP/1.1
Host: support-stage.mozilla.com
<snip>

HTTP/1.1 301 Moved Permanently
Date: Fri, 06 Aug 2010 08:39:07 GMT
Server: Apache/2.2.3 (Red Hat)
Location: http://support-stage.mozilla.com/en-US/questions?tagged=FxHome

Comment 10

[Vishal Kamdar [:vish_moz]]

updated redirect automated test:
http://viewvc.svn.mozilla.org/vc/projects/sumo/tests/frontend/python_tests/test_rewrites.py?revision=75452&view=markup&sortby=date