The default bug view has changed. See this FAQ.

Move the jpeg code to a saner location

RESOLVED FIXED

Status

()

Core
ImageLib
RESOLVED FIXED
7 years ago
6 years ago

People

(Reporter: jrmuizel, Unassigned)

Tracking

Trunk
x86
Mac OS X
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Reporter)

Description

7 years ago
The consensus seems to be that it belongs in media/jpeg

Comment 1

7 years ago
See https://bugzilla.mozilla.org/show_bug.cgi?id=573948#c97

Comment 2

7 years ago
A couple of suggestions
Right now everything in media is referred to by its library name so I would suggest something like media/libjpeg or media/libjpegturbo just to keep a consistent naming convention throughout the whole folder. It also helps anyone glancing at the source tree which library is being used e.g. libvpx instead of VP8.

Secondly if jpeg is being moved doesn't it make sense to move modules/libimg/png to media/libpng as well?

Updated

6 years ago
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → WONTFIX
I don't think this is WONTFIX. $(topsrcdir)/jpeg is a terrible location for libjpeg.
Status: RESOLVED → REOPENED
Resolution: WONTFIX → ---
Sure, let's get this discussion started again and post a patch then.

Do we have consensus on media/libjpeg?
(In reply to Benoit Girard (:BenWa) from comment #4)
> Sure, let's get this discussion started again and post a patch then.

I'm on it.

> Do we have consensus on media/libjpeg?

Hear hear!
(In reply to Bobby Holley (:bholley) from comment #5)
> I'm on it.

Posting a patch or discussing ;)? If not I'll gladly do it. Is 'hg move' sufficient or do we use something else to preserve history and whatnot?
hg move is it!
(In reply to Benoit Girard (:BenWa) from comment #6)
> (In reply to Bobby Holley (:bholley) from comment #5)
> > I'm on it.
> 
> Posting a patch or discussing ;)?

Both. I've got patches building to move libjpeg and libpng into media. If all goes well, I'll post 'em here for review.
That's great. Thanks for doing this!
Created attachment 565713 [details] [diff] [review]
part 1 - Move libjpeg to media/libjpeg. v1

Several tries later, I've got a patch that builds and, hopefully, catches all the edge cases.

This patch does jpeg. Flagging khuey for review.
Attachment #565713 - Flags: review?(khuey)
Created attachment 565714 [details] [diff] [review]
part 2 - Move libpng to media/libpng. v1

And this one does png.
Attachment #565714 - Flags: review?(khuey)
Attachment #565713 - Flags: review?(khuey) → review+
Attachment #565714 - Flags: review?(khuey) → review+
Landed to mozilla-central:
https://hg.mozilla.org/mozilla-central/rev/17405b1eb600
https://hg.mozilla.org/mozilla-central/rev/e29520632bf3

Resolving fixed.
Status: REOPENED → RESOLVED
Last Resolved: 6 years ago6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.