Closed Bug 584894 Opened 10 years ago Closed 8 years ago

Move the jpeg code to a saner location

Categories

(Core :: ImageLib, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: jrmuizel, Unassigned)

Details

Attachments

(2 files)

The consensus seems to be that it belongs in media/jpeg
A couple of suggestions
Right now everything in media is referred to by its library name so I would suggest something like media/libjpeg or media/libjpegturbo just to keep a consistent naming convention throughout the whole folder. It also helps anyone glancing at the source tree which library is being used e.g. libvpx instead of VP8.

Secondly if jpeg is being moved doesn't it make sense to move modules/libimg/png to media/libpng as well?
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → WONTFIX
I don't think this is WONTFIX. $(topsrcdir)/jpeg is a terrible location for libjpeg.
Status: RESOLVED → REOPENED
Resolution: WONTFIX → ---
Sure, let's get this discussion started again and post a patch then.

Do we have consensus on media/libjpeg?
(In reply to Benoit Girard (:BenWa) from comment #4)
> Sure, let's get this discussion started again and post a patch then.

I'm on it.

> Do we have consensus on media/libjpeg?

Hear hear!
(In reply to Bobby Holley (:bholley) from comment #5)
> I'm on it.

Posting a patch or discussing ;)? If not I'll gladly do it. Is 'hg move' sufficient or do we use something else to preserve history and whatnot?
hg move is it!
(In reply to Benoit Girard (:BenWa) from comment #6)
> (In reply to Bobby Holley (:bholley) from comment #5)
> > I'm on it.
> 
> Posting a patch or discussing ;)?

Both. I've got patches building to move libjpeg and libpng into media. If all goes well, I'll post 'em here for review.
That's great. Thanks for doing this!
Several tries later, I've got a patch that builds and, hopefully, catches all the edge cases.

This patch does jpeg. Flagging khuey for review.
Attachment #565713 - Flags: review?(khuey)
And this one does png.
Attachment #565714 - Flags: review?(khuey)
Landed to mozilla-central:
https://hg.mozilla.org/mozilla-central/rev/17405b1eb600
https://hg.mozilla.org/mozilla-central/rev/e29520632bf3

Resolving fixed.
Status: REOPENED → RESOLVED
Closed: 8 years ago8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.