584894 - Move the jpeg code to a saner location

Status: RESOLVED FIXED

(Core :: Graphics: ImageLib, defect)

Description

[Jeff Muizelaar [:jrmuizel]]

The consensus seems to be that it belongs in media/jpeg

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

See https://bugzilla.mozilla.org/show_bug.cgi?id=573948#c97

Comment 2

[atzaus]

A couple of suggestions
Right now everything in media is referred to by its library name so I would suggest something like media/libjpeg or media/libjpegturbo just to keep a consistent naming convention throughout the whole folder. It also helps anyone glancing at the source tree which library is being used e.g. libvpx instead of VP8.

Secondly if jpeg is being moved doesn't it make sense to move modules/libimg/png to media/libpng as well?

Comment 3

[Bobby Holley (:bholley)]

I don't think this is WONTFIX. $(topsrcdir)/jpeg is a terrible location for libjpeg.

Comment 4

[Benoit Girard (:BenWa)]

Sure, let's get this discussion started again and post a patch then.

Do we have consensus on media/libjpeg?

Comment 5

[Bobby Holley (:bholley)]

(In reply to Benoit Girard (:BenWa) from comment #4)
> Sure, let's get this discussion started again and post a patch then.

I'm on it.

> Do we have consensus on media/libjpeg?

Hear hear!

Comment 6

[Benoit Girard (:BenWa)]

(In reply to Bobby Holley (:bholley) from comment #5)
> I'm on it.

Posting a patch or discussing ;)? If not I'll gladly do it. Is 'hg move' sufficient or do we use something else to preserve history and whatnot?

Comment 7

[Joe Drew (not getting mail)]

hg move is it!

Comment 8

[Bobby Holley (:bholley)]

(In reply to Benoit Girard (:BenWa) from comment #6)
> (In reply to Bobby Holley (:bholley) from comment #5)
> > I'm on it.
> 
> Posting a patch or discussing ;)?

Both. I've got patches building to move libjpeg and libpng into media. If all goes well, I'll post 'em here for review.

Comment 9

[Benoit Girard (:BenWa)]

That's great. Thanks for doing this!

Comment 10

[Bobby Holley (:bholley)]

Attachment: part 1 - Move libjpeg to media/libjpeg. v1

Several tries later, I've got a patch that builds and, hopefully, catches all the edge cases.

This patch does jpeg. Flagging khuey for review.

Comment 11

[Bobby Holley (:bholley)]

Attachment: part 2 - Move libpng to media/libpng. v1

And this one does png.

Comment 12

[Bobby Holley (:bholley)]

Landed to mozilla-central:
https://hg.mozilla.org/mozilla-central/rev/17405b1eb600
https://hg.mozilla.org/mozilla-central/rev/e29520632bf3

Resolving fixed.