Closed Bug 584944 Opened 14 years ago Closed 14 years ago

Intermittent browser_uninstalling.js | Timed out

Categories

(Toolkit :: Add-ons Manager, defect)

Product:
Toolkit
Component:
Add-ons Manager
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
VERIFIED FIXED
Milestone:
mozilla2.0b7

People

(Reporter: philor, Assigned: robert.strong.bugs)

References

Details

(Keywords: intermittent-failure)

Attachments

(1 file, 2 obsolete files)

patch
2.15 KB, patch
mossop
: review+
Details | Diff | Splinter Review 
I vaguely suspect this of actually being bug 584613, but I can't point to any smoking files that failing to load would inevitably lead to nothing but a timeout. At any rate, it's been going on for at least a day now, but nobody felt like filing it.

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1281065014.1281067975.19880.gz
WINNT 5.2 mozilla-central debug test mochitest-other on 2010/08/05 20:23:34
s: win32-slave54

TEST-PASS | chrome://mochikit/content/browser/toolkit/mozapps/extensions/test/browser/browser_uninstalling.js | Should be displaying the correct UI
TEST-UNEXPECTED-FAIL | chrome://mochikit/content/browser/toolkit/mozapps/extensions/test/browser/browser_uninstalling.js | Timed out
TEST-UNEXPECTED-FAIL | chrome://mochikit/content/browser/toolkit/mozapps/extensions/test/browser/browser_uninstalling.js | Found a tab after previous test timed out: about:addons
I'm more inclined to say that this test is just running long. From the log file it appears that the test was attempting to continue to run after the harness decided it had timed out. Windows debug tends to be the slowest so if this test is on the verge of taking 30 seconds already (quite possible given how much it does I think) then it may just be tripping over occasionally. I'll look at adding some timing tomorrow so we can see how long it takes in passing cases.
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1281046237.1281049551.25988.gz
WINNT 5.2 mozilla-central debug test mochitest-other on 2010/08/05 15:10:37
s: win32-slave56

TEST-PASS | chrome://mochikit/content/browser/toolkit/mozapps/extensions/test/browser/browser_uninstalling.js | Should be closing window with correct URI
TEST-UNEXPECTED-FAIL | chrome://mochikit/content/browser/toolkit/mozapps/extensions/test/browser/browser_uninstalling.js | Timed out
Filed bug 585396 on adding some timing info to all browser-chrome tests.
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1281416969.1281419952.6291.gz
WINNT 5.2 mozilla-central debug test mochitest-other on 2010/08/09 22:09:29
s: win32-slave23

TEST-UNEXPECTED-FAIL | chrome://mochikit/content/browser/toolkit/mozapps/extensions/test/browser/browser_uninstalling.js | Timed out
philringnalda%gmail.com
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1281936712.1281939155.10599.gz
Rev3 MacOSX Snow Leopard 10.6.2 mozilla-central debug test mochitest-other on 2010/08/15 22:31:52

s: talos-r3-snow-004
TEST-UNEXPECTED-FAIL | chrome://mochikit/content/browser/browser/base/content/test/browser_bug553455.js | Timed out
TEST-UNEXPECTED-FAIL | chrome://mochikit/content/browser/browser/base/content/test/browser_bug553455.js | Found a tab after previous test timed out: http://example.com/browser/toolkit/mozapps/extensions/test/xpinstall/installtrigger.html?%7B%22Theme%20XPI%22%3A%22theme.xpi%22%7D
TEST-UNEXPECTED-FAIL | chrome://mochikit/content/browser/browser/base/content/test/browser_bug553455.js | Should have seen the right window open - Got chrome://browser/content/pageinfo/pageInfo.xul, expected chrome://mozapps/content/xpinstall/xpinstallConfirm.xul
TEST-UNEXPECTED-FAIL | chrome://mochikit/content/browser/toolkit/mozapps/extensions/test/browser/browser_manualupdates.js | Update item should have version number of the update - Got 1.0, expected 1.1
TEST-UNEXPECTED-FAIL | chrome://mochikit/content/browser/toolkit/mozapps/extensions/test/browser/browser_manualupdates.js |  - Got false, expected true
TEST-UNEXPECTED-FAIL | chrome://mochikit/content/browser/toolkit/mozapps/extensions/test/browser/browser_manualupdates.js | Release notes toggle should be visible - Got false, expected true
TEST-UNEXPECTED-FAIL | chrome://mochikit/content/browser/toolkit/mozapps/extensions/test/browser/browser_manualupdates.js | Timed out
TEST-UNEXPECTED-FAIL | chrome://mochikit/content/browser/toolkit/mozapps/extensions/test/browser/browser_manualupdates.js | Found a tab after previous test timed out: about:addons
TEST-UNEXPECTED-FAIL | chrome://mochikit/content/browser/toolkit/mozapps/extensions/test/browser/browser_uninstalling.js | Timed out
TEST-UNEXPECTED-FAIL | chrome://mochikit/content/browser/toolkit/mozapps/extensions/test/browser/browser_uninstalling.js | Found a tab after previous test timed out: about:addons
When I run this test locally with a windows debug build I get 137 of the following assertion:
###!!! ASSERTION: Wrong children repair!: 'parent == mParent', file d:/moz/_1_mozilla-central/mozilla/accessible/src/base/nsAccessible.cpp, line 2814

56 of the following assertion:
###!!! ASSERTION: No accessible parent for valid accessible!: 'parent', file d:/moz/_1_mozilla-central/mozilla/accessible/src/base/nsAccessible.cpp, line 2808

32 of the following assertion:
###!!! ASSERTION: Want to fire mutation events, but it's not safe: '(aNode->IsNodeOfType(nsINode::eCONTENT) && static_cast<nsIContent*>(aNode)-> IsInNativeAnonymousSubtree()) || sScriptBlockerCount == sRemovableScriptBlockerCount', file d:/moz/_1_mozilla-central/mozilla/content/base/src/nsContentUtils.cpp, line 3660

24 of the following assertion:
###!!! ASSERTION: Can only call this on frames that have been reflowed: '!(GetStateBits() & NS_FRAME_FIRST_REFLOW)', file d:/moz/_1_mozilla-central/mozilla/layout/generic/nsTextFrameThebes.cpp, line 2208

1 of the following assertion:
###!!! ASSERTION: Can't create document accessible!: 'docAcc', file d:/moz/_1_mozilla-central/mozilla/accessible/src/base/nsAccDocManager.cpp, line 333

and 1 of the following assertion which is likely not an issue:
###!!! ASSERTION: sqlite3_close failed. There are probably outstanding statements that are listed above!: 'srv == SQLITE_OK', file d:/moz/_1_mozilla-central/mozilla/storage/src/mozStorageConnection.cpp, line 629

I suspect the number of assertions is at the very least a contributing factor
After thinking about it this may be failing due to my system being a multitouch system which accessibility detects and enables itself when present.
I disabled accessibility which removed all of the assertions but the test still fails on my system with windows debug.
Attached patch patch rev1 (obsolete) — — Splinter Review 
This fixes the test for me. Yay!
Assignee: nobody → robert.bugzilla
Status: NEW → ASSIGNED
Attachment #487009 - Flags: review?(dtownsend)
Attached patch patch rev 2 (obsolete) — — Splinter Review 
potentially cleaner approach suggested by Mossop
Attached patch patch — — Splinter Review 

        Attachment #487009 -
        Attachment is obsolete: true

        Attachment #487017 -
        Attachment is obsolete: true

        Attachment #487023 -
        Flags: review?(dtownsend)

        Attachment #487009 -
        Flags: review?(dtownsend)

        Attachment #487023 -
        Flags: review?(dtownsend) → review+

    
    

    
  
Pushed to mozilla-central
http://hg.mozilla.org/mozilla-central/rev/271f7b7b11ee
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Flags: in-testsuite+
Flags: in-litmus-
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b7

    
    

    
  
Verified fixed on check-in and due to no more reported failures.
Status: RESOLVED → VERIFIED
OS: Windows Server 2003 → All
Hardware: x86 → All
Whiteboard: [orange]

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: