Closed Bug 584986 Opened 9 years ago Closed 8 years ago

Remove yahoo-ca.xml searchplugin, replace with bing.

Categories

(Mozilla Localizations :: ca / Catalan, defect)

defect
Not set

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: toniher, Assigned: toniher)

Details

Attachments

(2 files, 3 obsolete files)

After a long time of not being properly maintained, a few months ago Yahoo! stopped to offer Yahoo! Search in Catalan language (http://ct.search.yahoo.com). Now it redirects to an only Spanish language based version. Therefore, it does not fit anymore our quality standards and we would ask for its removal from Firefox searchplugins.
Stas, Seth?
Toni, I am assigning this to you.  Can you submit a patch for review, flagging me (:sethb)?  

Can your team also consider replacing the Yahoo plugin with something in the "general purpose" search category?  Are there other Catalan alternatives exist that are popular and your recommend?
Status: NEW → ASSIGNED
(In reply to comment #2)

> Can your team also consider replacing the Yahoo plugin with something in the
> "general purpose" search category?  Are there other Catalan alternatives exist
> that are popular and your recommend?

Despite not too popular, and far from perfect, I think we could only suggest Bing. A searchplugin like this could work: https://addons.mozilla.org/ca/firefox/addon/10434 unless there might be any license or alike issue associated.
(In reply to comment #3)
> (In reply to comment #2)
> 
> > Can your team also consider replacing the Yahoo plugin with something in the
> > "general purpose" search category?  Are there other Catalan alternatives exist
> > that are popular and your recommend?
> 
> Despite not too popular, and far from perfect, I think we could only suggest
> Bing. A searchplugin like this could work:
> https://addons.mozilla.org/ca/firefox/addon/10434 unless there might be any
> license or alike issue associated.

Can you create a patch and attach it to this bug?
Attachment #464610 - Flags: review?(sethb)
Comment on attachment 464610 [details] [diff] [review]
Patch remove yahoo-ca and add bing for ca locale

Hey Toni,

This is really close, and I have a small nit that prevents the r+.  Typically, we like to "parameterize" (sorry for the made up word) the <URL type> sections.  If you take a look at the Yahoo! plugin, we have two parameters there:

<Param name="p" value="{searchTerms}"/>
<Param name="ei" value="UTF-8"/>

You should be able to do this with both the "text/html" and "application/x-suggestions+json" lines for the Bing plugin.  

For instance, the "text/html" string should look something like this:

<Url type="text/html" template="http://www.bing.com/search">
  <Param name="q" value="{searchTerms}"/>
  <Param name="form" value="OSDSRC"/>
</Url>

For "application/x-suggestions+json", it should appear like this:

<Url type="application/x-suggestions+json" template="http://api.bing.com/osjson.aspx"/>
  <Param name="query" value="{searchTerms}"/>
  <Param name="language" value="{language}"/>
  <Param name="form" value="OSDJAS"/>
</Url>

Can you create a new patch after testing the plugin with these changes?  Make sure to note the version on which you successfully tested.  

Thanks!
Attachment #464610 - Flags: review?(sethb) → review-
The Bing plugin would also need a <SearchForm>http://www.bing.com/</SearchForm> line near the end.

Also, I think it would be wise to split this patch into two patches: one to remove yahoo!, and the other one to add bing. The reason for this is that we should reach out to Bing and ask them for a permission to use their plugin. So we can first remove the yahoo! plugin with the first patch, and the add bing with the other one.
Attached patch Yahoo removal patch (obsolete) — Splinter Review
Attachment #464610 - Attachment is obsolete: true
Attachment #464748 - Flags: review?(sethb)
Attached patch Bing addition patch (obsolete) — Splinter Review
Attachment #464751 - Flags: review?(sethb)
Comment on attachment 464751 [details] [diff] [review]
Bing addition patch

This looks good to me.  But, please wait for a confirmation from Bing to check this into your Hg repository.  Once we have a confirmation, you can check in this change.

When you check it in, please annotate the check in with a comment like, "Bug 584986, adding Bing search plugin, r=sethb"
Attachment #464751 - Flags: review?(sethb) → review+
Comment on attachment 464748 [details] [diff] [review]
Yahoo removal patch

This looks good to me.  With this approval, please check in the change to your Hg repo, annotating the check in with a comment like, "Bug 584986, Removing Yahoo search plugin, r=sethb".

You should test the build before signing off.  Axel will need to see when he can get this change into the next minor release.  Not sure if it will happen this next turn.
Attachment #464748 - Flags: review?(sethb) → review+
(In reply to comment #11)
> Comment on attachment 464748 [details] [diff] [review]
> Yahoo removal patch
> 
> This looks good to me.  With this approval, please check in the change to your
> Hg repo, annotating the check in with a comment like, "Bug 584986, Removing
> Yahoo search plugin, r=sethb".
> 
> You should test the build before signing off.  Axel will need to see when he
> can get this change into the next minor release.  Not sure if it will happen
> this next turn.

Thanks!
Done for yahoo-ca: http://hg.mozilla.org/l10n-central/ca/rev/5e2f35752b94
I'm not sure, should we do this on 1.9.2?
Summary: Remove yahoo-ca.xml searchplugin → Remove yahoo-ca.xml searchplugin, replace with bing.
(In reply to comment #13)
> I'm not sure, should we do this on 1.9.2?

I know taking a change on 1.9.2 can be very unpredictable, but I think it is something we should put this into the schedule.  Catalan has a fairly large number of users and Yahoo! is no longer supporting Catalan search results.  Seems like a bad enough experience for our users to remove it.

What do you guys think?
If not a problem for you, I would do it in 1.9.2 as well. Would you only remove yahoo-ca or replace with bing at the same time?
How about we remove broken yahoo! search on 1.9.2 and central, but add bing on central only?
(In reply to comment #16)
> How about we remove broken yahoo! search on 1.9.2 and central, but add bing on
> central only?

Agreed for me. Letting aside nightlies, in central we would have some noticeable betas (some more people) who would try it out.
Comment on attachment 464748 [details] [diff] [review]
Yahoo removal patch

r- from me, sorry. You need to remove yahoo-ca from list.txt, too.

I'll reject the latest sign-off on fx40x on this, too, as it breaks the build.
Attachment #464748 - Flags: review-
Here removing in list.txt as well
Attachment #464748 - Attachment is obsolete: true
Attachment #465975 - Flags: review?(sethb)
Attachment #465975 - Flags: review?(l10n)
Attachment #465975 - Flags: review?(sethb)
Attachment #465975 - Flags: review?(l10n)
Attachment #465975 - Flags: review+
Attachment #464751 - Attachment is obsolete: true
Attachment #465976 - Flags: review?(sethb)
Attachment #465976 - Flags: review?(l10n)
Comment on attachment 465976 [details] [diff] [review]
Bing addition patch

Quick question before I r+ this one.  Is the "Bing. Search by Microsoft." in the <Description> tag how Bing wants it branded?  Should it be in Catalan?  Should it just be "Bing"?
Axel, are we landing the Yahoo! removal on 1.9.2?  Did you/Toni discuss that and confirm?  For what it's worth, I vote yes to do the Yahoo! plugin removal on 1.9.2.
Comment on attachment 465976 [details] [diff] [review]
Bing addition patch

I'd at least remove the contact entry.

I'm not sure if we're expected to send the form values like this. I guess we'll get the exact params when we get the permission from bing?

Also, we still have

browser.search.order.2=Yahoo

in region.properties. Do we want to remove that? Or even replace that with bing? Maybe a Kev question?

For 1.9.2, I'm fine with removing yahoo, I guess.
Attachment #465976 - Flags: review?(l10n) → review-
(In reply to comment #23)
> Comment on attachment 465976 [details] [diff] [review]
> Bing addition patch
> 
> I'd at least remove the contact entry.
> 
> I'm not sure if we're expected to send the form values like this. I guess we'll
> get the exact params when we get the permission from bing?
> 

Any news about this?

> For 1.9.2, I'm fine with removing yahoo, I guess.

Removed yahoo in 1.9.2:
http://hg.mozilla.org/releases/l10n-mozilla-1.9.2/ca/rev/6d6a5b3972ec
Well, after the announcement https://blog.mozilla.com/blog/2010/10/06/refreshing-the-firefox-search-bar/, we can continue in the same bug, can't we?

I guess I would only need to add bing in list.txt when updated in en-US Hg.
We'll get templates from Kev on how the plugins should look, we know as much as that they're different from en-US, much like yahoo is/was. But the exact details haven't made it into our inboxes yet.

But yeah, we're in a much smoother situation in terms of agreements and knowing how to proceed. And how to talk about it, too.
(In reply to comment #27)
> We'll get templates from Kev on how the plugins should look, we know as much as
> that they're different from en-US, much like yahoo is/was. But the exact
> details haven't made it into our inboxes yet.
> 
> But yeah, we're in a much smoother situation in terms of agreements and knowing
> how to proceed. And how to talk about it, too.

Thanks Axel for the info!
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Status: RESOLVED → VERIFIED
Attachment #465976 - Flags: review?(sethb)
You need to log in before you can comment on or make changes to this bug.