Closed Bug 585007 Opened 14 years ago Closed 14 years ago

Share a list of primary toolbarbuttons for use across themes

Categories

(Firefox :: Theme, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 4.0b5

People

(Reporter: dao, Assigned: dao)

Details

Attachments

(1 file, 1 obsolete file)

Attached patch patch (obsolete) — Splinter Review
pinstripe will probably want to use this as well
Attachment #463521 - Flags: review?(gavin.sharp)
Comment on attachment 463521 [details] [diff] [review]
patch

>diff --git a/browser/themes/shared.inc b/browser/themes/shared.inc

Can we use a different filename? browserShared.inc? Multiple shared.incs is kind of confusing.

>diff --git a/browser/themes/winstripe/browser/browser.css b/browser/themes/winstripe/browser/browser.css

>-%filter substitution

Doesn't hurt to leave this, does it?
Attachment #463521 - Flags: review?(gavin.sharp) → review+
Attached patch patchSplinter Review
made the suggested changes
Attachment #463521 - Attachment is obsolete: true
Attachment #468428 - Flags: approval2.0?
Attachment #468428 - Flags: approval2.0? → approval2.0+
http://hg.mozilla.org/mozilla-central/rev/019827f82e36
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 4.0b5
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: