585061 - No configure check for SSL_ENABLE_FALSE_START

Status: NEW

(Firefox Build System :: General, defect)

Description

[Micah Gersten]

3.12.7 is now required for mozilla central to build, but there's no configure check for it

Comment 1

[Micah Gersten]

Attachment: configure.in patch for bump to 3.12.7

Bump configure check for NSS to 3.12.7

Comment 2

[Wan-Teh Chang]

Micah: could you tell me why mozilla-central requires
NSS 3.12.7?  In fact, mozilla-central is now using
NSS 3.12.8 Beta 1.  I can help suggest the right version
of NSS to require.  Thanks.

Comment 3

[Kai Engert [:KaiE:]]

It may not be strictly required (no hard API requirement), but I agree it's a good idea to require that people don't build against older versions of NSS.

I guess it would make sense to require 3.12.7 on mozilla-1.9.2 for Firefox 3.6.x

Is the intention of this bug to upgrade mozilla-1.9.2, too?

Comment 4

[Micah Gersten]

(In reply to comment #2)

Here's the error I get when building:
/build/buildd/xulrunner-2.0-2.0~b3~hg20100804r48791+nobinonly/build-tree/mozilla/security/manager/ssl/src/nsNSSComponent.cpp: In member function 'nsresult nsNSSComponent::InitializeNSS(PRBool)':
/build/buildd/xulrunner-2.0-2.0~b3~hg20100804r48791+nobinonly/build-tree/mozilla/security/manager/ssl/src/nsNSSComponent.cpp:1712: error: 'SSL_ENABLE_FALSE_START' was not declared in this scope
/build/buildd/xulrunner-2.0-2.0~b3~hg20100804r48791+nobinonly/build-tree/mozilla/security/manager/ssl/src/nsNSSComponent.cpp: In member function 'virtual nsresult nsNSSComponent::Observe(nsISupports*, const char*, const PRUnichar*)':
/build/buildd/xulrunner-2.0-2.0~b3~hg20100804r48791+nobinonly/build-tree/mozilla/security/manager/ssl/src/nsNSSComponent.cpp:2243: error: 'SSL_ENABLE_FALSE_START' was not declared in this scope
make[6]: *** [nsNSSComponent.o] Error 1

I didn't see a bug for the landing of 3.12.8 beta 1, I guess that's actually what's needed to make this work.

(In reply to comment #3)
> It may not be strictly required (no hard API requirement), but I agree it's a
> good idea to require that people don't build against older versions of NSS.
> 
> I guess it would make sense to require 3.12.7 on mozilla-1.9.2 for Firefox
> 3.6.x
> 
> Is the intention of this bug to upgrade mozilla-1.9.2, too?

I was going to suggest it after landing of bug 575620, but per above, this isn't actually high enough.

@bsmedberg
Can we require a beta in configure?  Let me know what to do and I'll update the patch.

Comment 5

[Micah Gersten]

Changing blocking bug to the one enabling false start which is actually what fails.  Here's the commit that landed 3.12.8 beta 1:
http://hg.mozilla.org/mozilla-central/rev/8638116b698f

Comment 6

[Micah Gersten]

Comment on attachment 463553 [details] [diff] [review]
configure.in patch for bump to 3.12.7

Removing review until I know what can be put in configure.

Comment 7

[Kai Engert [:KaiE:]]

(In reply to comment #4)
> In member function 'nsresult nsNSSComponent::InitializeNSS(PRBool)':
> /build/buildd/xulrunner-2.0-2.0~b3~hg20100804r48791+nobinonly/build-tree/mozilla/security/manager/ssl/src/nsNSSComponent.cpp:1712:
> error: 'SSL_ENABLE_FALSE_START' was not declared in this scope


Ok, sorry. Yes, Wan-Teh already landed 3.12.8 beta into mozilla-central, and a small patch that controls a new feature included in 3.12.8 beta.

The symbolic definition SSL_ENABLE_FALSE_START is new in 3.12.8

In my opinion it should be fine to bump the version requirement in configure to 3.12.8, despite it being a beta.

Given mozilla-central and Firefox 4 are still at beta stage, it's fine to ship a NSS beta.

mozilla-central must be upgraded to "at least" NSS 3.12.8 final before the final FF 4 release, but there's plenty of time, and it will happen in time.

Comment 9

[Mike Hommey [:glandium]]

As I wrote in bug 585110, and as it is done in the patch there, the nspr version requirement should be bumped to 4.8.6, too.

Comment 10

[Micah Gersten]

(In reply to comment #9)
> As I wrote in bug 585110, and as it is done in the patch there, the nspr
> version requirement should be bumped to 4.8.6, too.

I actually already had bug 567620 open for a bump of NSPR in configure.

Comment 11

[Micah Gersten]

Attachment: configure.in patch for NSS version bump to 3.12.8

Per comment 7 adding diff to bump configure to 3.12.8 for NSS

Comment 12

[Micah Gersten]

Block bug 583908 since it's the one for landing in Core vs the other bug which was for NSS.

Comment 13

[Wan-Teh Chang]

Micah: detecting SSL_ENABLE_FALSE_START doesn't require a configure check.
Also, TLS false start is an optional feature, so it's fine to build Mozilla with
an older version of NSS that doesn't support TLS false start.

I will address the SSL_ENABLE_FALSE_START issue in bug 583908.

Comment 14

[Micah Gersten]

Unassigning myself since per comment 13 pending fix in the other bug.

Comment 15

[Micah Gersten]

Comment on attachment 463607 [details] [diff] [review]
configure.in patch for NSS version bump to 3.12.8

Cancelling review again, sorry for the noise bsmedberg